Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

FindModifiedVideos call has incorrect documentation. #5

Open
tgoldenatwork opened this issue Nov 28, 2012 · 3 comments
Open

FindModifiedVideos call has incorrect documentation. #5

tgoldenatwork opened this issue Nov 28, 2012 · 3 comments

Comments

@tgoldenatwork
Copy link

pageSize and pageNumber in FindModifiedVideos() from the ReadApi are documented as optional nullable values. If null is passed for either of these values, the API crashes.

pageSize may not be omitted, since if is compared to MAX_VIDEOS_PER_PAGE without checking whether it is null. Autoboxing a null Integer to a primitive int results in a NullPointerException.

@three4clavin
Copy link
Contributor

I'll have a look at both of these, although there are default values imposed by the Media API services, so omitting them would only be a small convenience. E.g. if you leave out pageSize, you'll get a max page size of 100 (the absolute max allowed by all read api calls). If you leave pageNumber out, you'll get the first page. So the work around would be to simply set these to 100 and 1 even if you don't care about the actual values for some reason.

@tgoldenatwork
Copy link
Author

That's fine, as long as they are documented as such.

@three4clavin
Copy link
Contributor

4.1.9 just cut - if you pass null in now for page size, page number, sort by or sort order, those params should simply be left off the URL request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants