Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error in UI when 500 is returned #1223

Closed
elcojacobs opened this issue Apr 13, 2020 · 1 comment · Fixed by #1225
Closed

Show error in UI when 500 is returned #1223

elcojacobs opened this issue Apr 13, 2020 · 1 comment · Fixed by #1225
Projects
BrewBlox

Comments

@elcojacobs
Copy link
Member

When devcon throws a 500, the only way to see it is to dig into the network tab of the debugger.

We should show the actual error in the UI, not just 500.
Maybe we need to use a different error code for firmware errors, as this is not really a server error in devcon, but a response from firmware.
@steersbob steersbob added this to Accepted in BrewBlox via automation Apr 13, 2020
@steersbob steersbob moved this from Accepted to Next in BrewBlox Apr 13, 2020
@steersbob
Copy link
Member

https://github.com/BrewBlox/brewblox-devcon-spark/blob/develop/brewblox_devcon_spark/exceptions.py defines the non-500 exceptions.

Issue seems related to axios/axios#960

@steersbob steersbob mentioned this issue Apr 13, 2020
Merged
BrewBlox automation moved this from Next to Closed Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
BrewBlox
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use response data in error notify steersbob/brewblox-ui
2 participants
@elcojacobs @steersbob