Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Android Setup Documentation #28

Open
stevecarlton opened this issue Jan 24, 2021 · 2 comments
Open

Updates to Android Setup Documentation #28

stevecarlton opened this issue Jan 24, 2021 · 2 comments

Comments

@stevecarlton
Copy link

Just went through the Android setup documentation for this plugin, located here: https://help.branch.io/developers-hub/docs/capacitor

I noticed a few discrepancies/opportunities for clarification for someone like me that has no native Android knowledge:

  1. In the first Android bullet point "If your app is in the Google Play Store, update build.gradle...". It would be helpful to highlight that the correct file is android/app/build.gradle and NOT android/build.gradle
  2. Would be helpful to know where to put CustomApplicationClass.java
  3. In the CustomApplicationClass.java section, the filename indicated at the top of the code snippet refers incorrectly AndroidManifest.xml.

Thought this might be best shared here but let me know if I should send this somewhere else.

@webuniverseio
Copy link

I'm in a similar situation, would be nice for branch team to review. It is also not clear if <_ name="branch_test_mode">true</_> should be a string or bool, because right now it is both due to a typo

@Brandi-Youreka
Copy link

I am also a bit confused as to where to put the CustomApplicationClass.java file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants