Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-admins can't edit and save recipients for notifications #359

Open
edwinsiebel opened this issue Jun 22, 2021 · 2 comments
Open

Non-admins can't edit and save recipients for notifications #359

edwinsiebel opened this issue Jun 22, 2021 · 2 comments
Labels

Comments

@edwinsiebel
Copy link

Bug description

You have the possibility to filter the capabilites using the notification/post_type/capabilities hook.

When you change this to a value not manage_options, the API to endpoints of /repeater-field/(?P<id>\d+), /section-repeater-field/(?P<id>\d+) or repeater-field/select are only accessible by the capability manage_options. See example.

The problem with this, when a user without the cap manage_options, and he/she edits a notification with one or more recipient repeat-fields, this user does not see the repeat-fields (a 403 response is given when fetching the fields). And when this user saves the notification, the recipients fields are not saved to the notification, which results in no recipients getting mailed.

Expected behavior

The repeated fields should be accessible to anyone who has the ability to edit notifications.

Environment

  • PHP: 7.4
  • WordPress: 5.7.2
  • Notification plugin: 7.2.4

Screenshots

Admin user:
admin

Editor user:
editor

@jakubmikita
Copy link
Member

Thanks for the report @edwinsiebel ! This should be an easy fix. I'll make sure to attach the changelog here if you'd like to hotfix before the next release.

@edwinsiebel
Copy link
Author

Great, if you need any help, let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants