Updated the rangeContainsValueModulo... function to use absolute values ... #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (modulus algorithms often break with negative numbers)
|
After looking at this again, there is definitely a risk of "false positives" being returned from the function, which would attempt to process annotations that are not, in fact, on the screen. This could impact performance, but for my needs, I'm fine with it. Surely someone out there knows more about the algorithm than me though... |
|
We use your fix in a fork of this repo. It would be great if would be merged into the main project. |
|
++ Please take this merge. Functionality is basically busted without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32
modulus algorithms often break with negative numbers