Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program icon #61

Open
Mirdarthos opened this issue Dec 23, 2021 · 13 comments
Open

Program icon #61

Mirdarthos opened this issue Dec 23, 2021 · 13 comments

Comments

@Mirdarthos
Copy link

Mirdarthos commented Dec 23, 2021

Current behavior

https://i.imgur.com/gsHNY7w.png

As cam be seen in the screenshot, Boostnote doesn't use the icon assigned to it, neither in the Task Switcher, nor as the program's icon.

Expected behavior

At first I thought it was .AppImage behaviour, as I don't use many .AppImages. But then I noticed it's working more than 100% fine with another .AppImage that I use. So it's obviously not that.

Steps to reproduce

Open the program and switch about. Alt+Tab

Environment

  • Boost Note.next version: 0.22.3
  • OS version and name: Manjaro Linux 21.2rc Qonos, KDE.
@Komediruzecki
Copy link
Collaborator

Hi,

I didn't encounter this issue in Ubuntu, cannot really test it quickly on Manjaro, can you provide me some info about the setup, this happens on 0.22.3 but not on all previous releases?

Do you have some icon customization for the app, do you maybe have multiple apps, did you try reinstalling, or maybe the Manjaro uses the default icon is it cannot process it correctly?

@Mirdarthos
Copy link
Author

Mirdarthos commented Jan 4, 2022

Hi again,

Please see https://imgur.com/8OMxBHi

Explanation:

This has happened since I've started using Boostnote. As I explained previously, I thought this was normal, until Ferdi's icon (https://getferdi.com/) proved differently. And Ferdi is my only other .AppImage.

Some more information:

  • OS: Manjaro Linux x86_64
  • Host: Z370 HD3
  • Kernel: 5.16.0-1-MANJARO
  • Uptime: 51 mins
  • Packages: 1912 (pacman), 46 (flatpak)
  • Shell: /usr/bin/zsh 5.8
  • Resolution: 2560x1080 @ 60.00Hz, 2560x1080 @ 60.00Hz
  • DE: Plasma 5.23.4
  • WM: KWin
  • WM Theme: Twilight-dark
  • Theme: Arc Dark [Plasma]
  • Icons: Sweet-Rainbow [Plasma]
  • Terminal: yakuake
  • CPU: Intel i7-8700 (6) @ 4.3GHz [36.0°C]
  • GPU: NVIDIA GeForce GTX 960
  • GPU Driver: NVIDIA 495.44
  • Memory: 5618MiB / 15949MiB (35%)
  • Disk (/): 125G / 221G (60%)
  • Disk (/mnt/5TB): 2.7T / 4.6T (63%)

The icon theme is Sweet rainbow, but it uses Candy Icons as fallback if an icon can not be found, of which Boostnote is one.

This has also happened with all previous kernel versions that I've tried. (So version 5.4, 5.10, and 5.15 as well) along with all versions of KDE I've used so far.

Manjaro isn't like Ubuntu in that it has release versions. It is a rolling release O.S. And mine is fully updated.

Any other info I can provide?

Edit:

Just had a brain-fart moment, what is the class of the Boostnote window? AFAIK if the icon is the same name as the class it should match up. Or something to that effect.

@Komediruzecki
Copy link
Collaborator

Hi,

Thx for all the info, yeah it seems that your lib is defaulting to some icon.

The boost note app is written in electron, not sure which class their windows are, what do you mean by window class?
Its this object: https://www.electronjs.org/docs/v14-x-y/api/browser-window

@Mirdarthos
Copy link
Author

Hi,

I know, have known for some time, that's why I use it, the Boostnote is written in Electron.

From what I can gather in KDE, the window class has to do, no is essential to window identification. Similar to a eleement class in HTML. See below for what I could get about the Boostnote app:

https://imgur.com/0rViSO9

@Komediruzecki
Copy link
Collaborator

Maybe the icon provider have old boostnote window/app name, since now there are two, local space app and cloud app, I cannot really change this to be same as of cloud, so I guess they sohuld offer two icons, since app icons are also different in our apps.

Let me know if you think there is some other solution, do you know what should window class match or app name to get correct icon?

@Mirdarthos
Copy link
Author

Mirdarthos commented Jan 5, 2022

Well, I have no idea, to be honest.

I thought it would work if the class is added in the/a .desktop it would work. So I tested right now. I added:

--class=BoostnoteWindow to the e nd of the Exec= line, so that it's now:

Exec=/home/mirdarthos/Applications/boost-note-local-linux.AppImage --class=BoostnoteWindow

Then I added a StartupWMClass line:

StartupWMClass=BoostnoteWindow

Finally, just for thoroughness, I changed the Icon line (although I'll change it back now since it made no difference.):

Icon=/home/mirdarthos/.local/share/icons/candy-icons/apps/scalable/boostnote.svg

When running it with the .desktop file, there was absolutely 0 difference.

I suspected it'd work because I once used this method to launch 2 Firefox profiles simultaneously, each with its own icon. Alas, it did absolutely nothing.

@Komediruzecki
Copy link
Collaborator

Hi,

If it is not such a hurry for you, I can take some time to inspect the issue, I assume the packages for icons are available for ubuntu as well, meaning I could try it on my OS?

@Mirdarthos
Copy link
Author

Hi,

I think it's safe to say that I'm not in a hurry, seeing as I'm used to it, like I previously said.

Take a look at Ferdi (https://getferdi.com/), perhaps you'll see something there. Ferdi and Boostnote are the only two .AppImage containers I use, as I mentioned, and Ferdi works correctly. Or at least, if I did something, it was so long ago the
I can't remember it any more and the change has survived all updates that I wasn't reminded of it.

The icon theme in question is Candy Icons by eliverlara available on the KDE store at https://store.kde.org/p/1305251/ and also here, on Github, at https://github.com/EliverLara/candy-icons but IIRC it happened with the stock icon from it as well.

@Komediruzecki
Copy link
Collaborator

Thx for the info, I looked a bit into it, but will try to reproduce it on my system tomorrow

@Mirdarthos
Copy link
Author

I just came across this: https://superuser.com/questions/1015796/in-kde-plasma-5-how-to-i-create-standalone-launchers-desktop-shortcuts-to-web-a/1068709

And thought it might apply, since Boostnote uses Electron, which in turn uses Chromium...

@Mirdarthos
Copy link
Author

Mirdarthos commented Apr 14, 2022

Hi again,

I'm not exactly sure what you did or didn't do, but it seems better. The icon is right in the taskbar, but the program and task switcher icon is still the wrong one. See:

https://i.imgur.com/p3I9m1C.png

Also, for another example of an .AppImage that works correctly, see https://github.com/TheGoddessInari/hamsket

@Komediruzecki
Copy link
Collaborator

Hi again,

I'm not exactly sure what you did or didn't do, but it seems better. The icon is right in the taskbar, but the program and task switcher icon is still the wrong one. See:

https://i.imgur.com/p3I9m1C.png

Also, for another example of an .AppImage that works correctly, see https://github.com/TheGoddessInari/hamsket

Hi,

I don't think we did anything yet, but maybe some lib update or ecosystem change was fixed.

Nevertheless, sorry for long delay, I'll check everything this weekend and see if we can fix remaining ones.

@Mirdarthos
Copy link
Author

No worries whatsoever! Take your time!

I just gave an update when I saw something different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants