Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateTwitterValues breaks Chromium #22

Open
organisciak opened this issue Apr 2, 2015 · 4 comments
Open

updateTwitterValues breaks Chromium #22

organisciak opened this issue Apr 2, 2015 · 4 comments
Labels

Comments

@organisciak
Copy link
Member

Via @bmschmidt: line 561 of a.js, where it calls updateTwitterValues, breaks the whole site in Chromium, OS X 10.9.

Ben's suggestion is catching errors.

@bmschmidt
Copy link
Member

The main page at bookworm.culturomics.org is still broken for me on Chromium on account (AFAICT) of the twitter box. (Safari is fine). Is that reflecting the new code, or is it an old version?

Here's the console state after it's failed:

image

@bmschmidt bmschmidt reopened this Apr 3, 2015
@sa501428
Copy link
Member

sa501428 commented Apr 3, 2015

Oh, bookworm.culturomics.org is still on the old version.
What's the exact url though?

I will update it soon. But there will be a lot of restructuring involved as there are way too many redundant files on that web server.

@bmschmidt
Copy link
Member

Oh sorry, I meant to say http://bookworm.htrc.illinois.edu as a landing
page doesn't work for me--the one that tries to display a list of tweets
under the chart, 4m edition.
On Fri, Apr 3, 2015 at 3:35 PM Muhammad Saad Shamim <
notifications@github.com> wrote:

Oh, bookworm.culturomics.org is still on the old version.
What's the exact url though?

I will update it soon. But there will be a lot of restructuring involved
as there are way too many redundant files on that web server.


Reply to this email directly or view it on GitHub
#22 (comment)
.

sa501428 added a commit that referenced this issue Apr 3, 2015
Fixed handling for twitter/goo.gl links
@organisciak
Copy link
Member Author

I need to merge fix over to the proper branch. Will do that now.

On Fri, Apr 3, 2015, 3:24 PM Benjamin Schmidt notifications@github.com
wrote:

Oh sorry, I meant to say http://bookworm.htrc.illinois.edu as a landing
page doesn't work for me--the one that tries to display a list of tweets
under the chart, 4m edition.
On Fri, Apr 3, 2015 at 3:35 PM Muhammad Saad Shamim <
notifications@github.com> wrote:

Oh, bookworm.culturomics.org is still on the old version.
What's the exact url though?

I will update it soon. But there will be a lot of restructuring involved
as there are way too many redundant files on that web server.


Reply to this email directly or view it on GitHub
<#22
issuecomment-89400300>
.


Reply to this email directly or view it on GitHub
#22 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants