Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated log Filter when closing RabbitmqBroker many times #559

Open
7 tasks done
gagtomm1 opened this issue Jul 7, 2023 · 0 comments
Open
7 tasks done

Duplicated log Filter when closing RabbitmqBroker many times #559

gagtomm1 opened this issue Jul 7, 2023 · 0 comments
Labels
beginner friendly Enhancements or issues that are easy for someone to get started on. bug

Comments

@gagtomm1
Copy link

gagtomm1 commented Jul 7, 2023

Checklist

  • Does your title concisely summarize the problem?
  • Did you include a minimal, reproducible example?
  • What OS are you using?
  • What version of Dramatiq are you using?
  • What did you do?
  • What did you expect would happen?
  • What happened?

What OS are you using?

Windows 10

What version of Dramatiq are you using?

1.14.2

What did you do?

Using the RabbitmqBroker, publish a message actor.send(...) then call broker.close() more than 1 time. Looking at the code, it might not be required to publish a message.

What did you expect would happen?

A broker can be closed many times without side effect.

What happened?

One of the step of the close() method is to silence some noisy loggers. After leaving my application running for a while, I noticed that the same log filter is added multiple times.
image

@Bogdanp Bogdanp added bug beginner friendly Enhancements or issues that are easy for someone to get started on. labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner friendly Enhancements or issues that are easy for someone to get started on. bug
Projects
None yet
Development

No branches or pull requests

2 participants