Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the fsfinder to use concurrency #61

Open
kehoecj opened this issue Oct 9, 2023 · 8 comments
Open

Update the fsfinder to use concurrency #61

kehoecj opened this issue Oct 9, 2023 · 8 comments
Labels
enhancement New feature or request validator-core Issues that relate to the core validator functionality

Comments

@kehoecj
Copy link
Contributor

kehoecj commented Oct 9, 2023

The current implementation of the file system finder is suitable for most use-cases but can get slow when recursing through a very large directory tree. It would improve performance to update the fsfinder to launch a new goroutine for each subdirectory. Determine a benchmark and determine if the worker pool needs to be limited to maximize performance as well as measuring the performance increase using goroutines

@kehoecj kehoecj added enhancement New feature or request validator-core Issues that relate to the core validator functionality hacktoberfest Hacktoberfest 2023 labels Oct 9, 2023
@AshwinKul28
Copy link

I can pick this up! @kehoecj

@kehoecj
Copy link
Contributor Author

kehoecj commented Oct 11, 2023

It's yours!

@kehoecj kehoecj removed the hacktoberfest Hacktoberfest 2023 label Oct 31, 2023
@kehoecj
Copy link
Contributor Author

kehoecj commented Oct 31, 2023

@AshwinKul28 Are you still interested in working on this issue?

@Axecalever
Copy link

@kehoecj, can I take this ?

@kehoecj
Copy link
Contributor Author

kehoecj commented Nov 23, 2023

@kehoecj, can I take this ?

Absolutely! I assigned it to you

@Axecalever
Copy link

@kehoecj is there any specific dataset of config files that I could benchmark against?

@kehoecj
Copy link
Contributor Author

kehoecj commented Nov 28, 2023

@kehoecj is there any specific dataset of config files that I could benchmark against?

No, we don't have a current dataset to benchmark against. It would be less about a dataset and more about a large tree of subdirectories, for instance running the validator against /etc, /, etc

@kehoecj
Copy link
Contributor Author

kehoecj commented Jan 19, 2024

@Axecalever Did you still want to work this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validator-core Issues that relate to the core validator functionality
Projects
None yet
Development

No branches or pull requests

3 participants