Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few sanity checks to the Convert Orientations filter #957

Open
imikejackson opened this issue May 10, 2024 · 1 comment
Open

Add a few sanity checks to the Convert Orientations filter #957

imikejackson opened this issue May 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request Feature Request

Comments

@imikejackson
Copy link
Contributor

A very easy way to mess up in the filter is to accidentally select "Orientation Matrix" instead of Quaternions because they are both next to each other in the combo box. Maybe we should put in a small sanity check section that does something like:

If the destination selection is Anything OTHER Than Quaternions and the output array starts with "quat" then we should throw a preflight error or at least a very strong warning that the user has most likely selected something inconsistent in the UI.

@imikejackson imikejackson added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request Feature Request labels May 10, 2024
@StopkaKris
Copy link

Hi @imikejackson,

Most of the filters require orientations as either Euler angles or quaternions. Are there any filters that require the orientation matrix, or do users convert orientations to the "Orientation Matrix" for the sole purpose of writing/exporting? Maybe that would help this issue, to let users know that they have selected an orientation representation (e.g., orientation matrix, rodriques vectors, etc.) that is not required/used by any filters and are solely for the user's benefit outside of DREAM.3D. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants