Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-dimensional attributes #40

Open
matz-e opened this issue Jul 17, 2019 · 3 comments
Open

Add support for multi-dimensional attributes #40

matz-e opened this issue Jul 17, 2019 · 3 comments

Comments

@matz-e
Copy link
Member

matz-e commented Jul 17, 2019

Essentially re-opening on #5

Using one-dimensional attributes for positions is fine, but for rotations we would prefer to use quaternions as has been the case in the past. From the official SONATA documentation:

users are strongly encouraged to only use quaternions due to its non ambiguity

Thus we should support multi-dimensional attributes. Alternatively, we could attempt to change the SONATA specification to allow orientation_{w,x,y,z} (I think this would be preferable?)

@matz-e
Copy link
Member Author

matz-e commented Jul 17, 2019

@mgeplf any preferences here? To be consistent, we already have 1-D positions for everything else… I can open a PR with the official SONATA folks.

@mgeplf
Copy link
Contributor

mgeplf commented Jul 17, 2019

I have a strong preference for quaternions (which is an aside).

Breaking out the attribute names reduces confusion, which I'm for, so I think that's a good proposal.

Idle thought: I wonder whether we can always get away with breaking multiple-dimension attributes apart - so far it has been the case, and so far it has always made sense.

@matz-e
Copy link
Member Author

matz-e commented Jul 17, 2019

See AllenInstitute/sonata#104

I will operate on the assumption that this will be merged (once it's merged, we can close this again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants