Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for Selection documentation. #293

Open
1uc opened this issue Oct 18, 2023 · 1 comment
Open

Improvement for Selection documentation. #293

1uc opened this issue Oct 18, 2023 · 1 comment
Assignees

Comments

@1uc
Copy link
Collaborator

1uc commented Oct 18, 2023

From the documentation it's unclear to me if a libsonata.Selection can be unsorted, or contain duplicate elements. What happens if the arguments to the ctor are unsorted or contain duplicate elements? It would be helpful to make the documentation explicit in this regard. Regarding selection.ranges do I get a copy or just a reference?

"The documentation" refers to:
https://libsonata.readthedocs.io/en/stable/#selection
https://libsonata.readthedocs.io/en/stable/api.html#libsonata.Selection

@mgeplf
Copy link
Contributor

mgeplf commented Oct 19, 2023

Good points, I will make that more clear.

@mgeplf mgeplf self-assigned this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants