Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCMfit@Misc is not to be trifled with! #56

Open
tcarruth opened this issue Mar 15, 2024 · 1 comment
Open

RCMfit@Misc is not to be trifled with! #56

tcarruth opened this issue Mar 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tcarruth
Copy link

Typically the idea of a Misc slot is somewhere the user can put things. If I put anything in here, downstream functions such as plot(RCMfit) fail to work! For example, I put a keepsims item for filtering simulations I wanted to leave out for obvious fitting issues:

RCMfit@Misc$keepsims = 1:24 # for example
plot(RCMfit) # error

@tcarruth tcarruth added the enhancement New feature or request label Mar 15, 2024
@quang-huynh
Copy link
Member

This is the likely culprit - https://github.com/Blue-Matter/SAMtool/blob/master/R/define_S4_class_RCModel.R#L179

Ideally, a new reporting slot is the best outcome and should be easy to update the plot function for backwards compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants