Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bppp: redesign generators API #220

Open
jonasnick opened this issue Mar 1, 2023 · 1 comment
Open

bppp: redesign generators API #220

jonasnick opened this issue Mar 1, 2023 · 1 comment

Comments

@jonasnick
Copy link
Contributor

See discussion here.

@jonasnick
Copy link
Contributor Author

The only two reasons I can come up with to have a secp256k1_bppp_generators object in the API are:

  1. Avoid hard coding too many generators in the source code. For single (unaggregated) rangeproofs, we need at most 71 generators, so I don't think this is a conern. We could easily hard code them and remove secp256k1_bppp_generators from the API.
  2. Allow using specific generators. We currently use this in testing to cross-test the rust and C implementation with diverging generator generation code. However, we could relatively easily hard code the same generators in the rust implementation.
    Another reason to use specific generators is that the rangeproof prover/verifier need to be aware of the "asset generator" and use it as one of the generators. But the asset generator is already an extra argument in the rangeproof API and does not require messing with secp256k1_bppp_generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant