Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8MB (or more) Motherboard Fastram with JIT and KMS triggers crash #1168

Open
solskogen opened this issue Nov 14, 2023 · 12 comments
Open

8MB (or more) Motherboard Fastram with JIT and KMS triggers crash #1168

solskogen opened this issue Nov 14, 2023 · 12 comments
Assignees
Labels

Comments

@solskogen
Copy link
Collaborator

With a A4000 or A4000T quickstart, adding 8MB or more Motherboard Fast ram crashes amiberry.

@solskogen
Copy link
Collaborator Author

Same with Processor slot Fast RAM

@midwan
Copy link
Collaborator

midwan commented Nov 14, 2023

This is something I cannot recreate, at least on the x86_64 version I'm testing with. We're going to need more specifics

@midwan midwan self-assigned this Nov 14, 2023
@solskogen
Copy link
Collaborator Author

Raspberry Pi 5, Raspberry Pi OS bookworm aarch64.

@solskogen
Copy link
Collaborator Author

Happens only when JIT is enabled.

@midwan
Copy link
Collaborator

midwan commented Nov 14, 2023

amiberry_crash.log

@midwan midwan changed the title Adding 8MB (or more) Motherboard Fastram crashes amiberry Adding 8MB (or more) Motherboard Fastram with JIT crashes amiberry Nov 14, 2023
@midwan
Copy link
Collaborator

midwan commented Nov 14, 2023

It doesn't happen on my Pi400, but I think I narrowed down when it probably happens.
I've made a small change in the commit above (in a separate branch), give it a try when you can and see if that helps or not!

@solskogen
Copy link
Collaborator Author

To make matters worse: It does not happen in sway or X11. Only in KMS.

@midwan midwan changed the title Adding 8MB (or more) Motherboard Fastram with JIT crashes amiberry 8MB (or more) Motherboard Fastram with JIT and KMS triggers crash Nov 15, 2023
@midwan
Copy link
Collaborator

midwan commented Dec 20, 2023

@solskogen does this happen on the preview branch? That one uses a completely different memory allocation routine, so maybe it helps

@solskogen
Copy link
Collaborator Author

Does that mean we have JIT for aarch64 on preview now? :-)

@midwan
Copy link
Collaborator

midwan commented Dec 20, 2023

Doh, I forgot this only happens with JIT - never mind :)

@midwan
Copy link
Collaborator

midwan commented Apr 5, 2024

Did some more testing today. This is not related to the memory allocation, but rather to something in the JIT implementation, in combination perhaps with newcpu. When this is triggered, the memory address retrieved in newcpu, seems to be invalid. Not sure why, but I suspect something in the JIT implementation, since it was designed to hit the memory directly at all times.

The preview branch has JIT for x86, but that's the "proper" version with indirect memory access if direct is not possible. I expect that one will work normally with KMSDRM as well.

@cmitu
Copy link
Contributor

cmitu commented May 5, 2024

Maybe something similar to raspberrypi/bookworm-feedback#107 ? You can try switching to a 4k page kernel by adding kernel=kernel8.img to /boot/firmware/config.txt and rebooting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants