Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CRT Guest Advanced as effect #860

Open
Jobima1st opened this issue Mar 25, 2024 · 3 comments
Open

Adding CRT Guest Advanced as effect #860

Jobima1st opened this issue Mar 25, 2024 · 3 comments
Labels
area: effect enhancement New feature or request

Comments

@Jobima1st
Copy link

Expected behavior 预期的功能

Hi
In case you don't know "CRT Guest Advanced" is the most advanced CRT shader that still get updates so it will be nice if it ported to Magpie

Also there are ntsc-adaptive to port as another option to use since there are only GTU_v050 in Magpie now

Alternative behavior (optional) 近似的功能(可选)

No response

@Jobima1st Jobima1st added the enhancement New feature or request label Mar 25, 2024
@Blinue
Copy link
Owner

Blinue commented Mar 26, 2024

CRT Guest Advanced: https://github.com/libretro/slang-shaders/blob/master/crt/crt-guest-advanced.slangp
NTSC-Adaptive: https://github.com/libretro/slang-shaders/blob/master/ntsc/ntsc-adaptive.slangp

These shaders look quite impressive, yet they’re also complex. It would be great to integrate them into Magpie. Thank you for your recommendation!

GitHub
Contribute to libretro/slang-shaders development by creating an account on GitHub.
GitHub
Contribute to libretro/slang-shaders development by creating an account on GitHub.

@Jobima1st
Copy link
Author

Jobima1st commented Apr 1, 2024

I just noted this https://github.com/SnowflakePowered/librashader
this should make all retroarch shaders run without any edit rather than port them one by one

GitHub
RetroArch Shaders for All . Contribute to SnowflakePowered/librashader development by creating an account on GitHub.

@Blinue
Copy link
Owner

Blinue commented Apr 2, 2024

The project was discussed in #785. Magpie has its own shader syntax, which is simple and efficient. Introducing a large third-party dependency may not be worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: effect enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants