-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task and Tag Preview Widget Refractor #99
Draft
javacafe01
wants to merge
9
commits into
master
Choose a base branch
from
tag_task_refractor
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
javacafe01
changed the title
Stop Recreating Widget Structure Every Time
Task and Tag Preview Widget Refractor
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a recent discussion with an AwesomeWM contributor, it should be better (maybe performance wise) to not recreate the widget on every hover/activation. Nevertheless, refactoring to this makes the code much simpler due to @undefinedDarkness's
widget_structure
PR. This will also mean that I have to implement awidget_structure
feature for thetag_preview
as mentioned in #98 @Nooo37.task_preview
widget_structure
feature intag_preview
Use newThis module is very buggy.awful.screenshot
module