Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task and Tag Preview Widget Refractor #99

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

javacafe01
Copy link
Member

@javacafe01 javacafe01 commented Aug 26, 2021

From a recent discussion with an AwesomeWM contributor, it should be better (maybe performance wise) to not recreate the widget on every hover/activation. Nevertheless, refactoring to this makes the code much simpler due to @undefinedDarkness's widget_structure PR. This will also mean that I have to implement a widget_structure feature for the tag_preview as mentioned in #98 @Nooo37.

  • Refractor task_preview
  • Refractor and implement widget_structure feature in tag_preview
  • Use new awful.screenshot module This module is very buggy.
  • Check if anything else needs this refractor

@javacafe01 javacafe01 mentioned this pull request Nov 22, 2022
@javacafe01 javacafe01 changed the title Stop Recreating Widget Structure Every Time Task and Tag Preview Widget Refractor Nov 22, 2022
@javacafe01 javacafe01 linked an issue Mar 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task Preview does not follow widget structure
2 participants