Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tabbed.iter less flash? #101

Open
v6cc opened this issue Aug 27, 2021 · 4 comments
Open

make tabbed.iter less flash? #101

v6cc opened this issue Aug 27, 2021 · 4 comments

Comments

@v6cc
Copy link

v6cc commented Aug 27, 2021

Could you make tabbed.iter less flash?

seems cause by turn on, turn off many times

@Nooo37
Copy link
Member

Nooo37 commented Aug 27, 2021

I'm not sure what you mean. Are you refering to the flash module that gets triggered when you are iterating through a tabbing group?

@v6cc
Copy link
Author

v6cc commented Aug 27, 2021

@Nooo37 not about flash module. I mean tabbed.iter -> tabbed.switch_to -> helper.turn_on helper.turn_off
so every time tabbed.iter , all tabbed clients will turn_on, turn off , every turn_off or turn_on will refresh screen, cause flash many times

@Nooo37
Copy link
Member

Nooo37 commented Aug 27, 2021

Ok I think I now know what you mean. Thanks for clarifying. I tried your earlier suggestion on the tabbed_improve_switch_to and couldn't get noticable improvements regarding the "flashing". I got "before" and "after" videos attached to the comment. I would be open to other suggestions but maybe that is a detail that doesn't lie in our hand to begin with 🤷

before.mp4
after.mp4

@v6cc
Copy link
Author

v6cc commented Aug 28, 2021

@Nooo37 I delete earlier suggestion because found them not really work ... sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants