Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next enhancements #2

Open
1 of 2 tasks
galvesribeiro opened this issue May 29, 2018 · 3 comments
Open
1 of 2 tasks

Next enhancements #2

galvesribeiro opened this issue May 29, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@galvesribeiro
Copy link
Member

galvesribeiro commented May 29, 2018

  • Make interfaces for both storages so it can make components testable
  • Make the concrete storage classes to have internal ctors
@galvesribeiro galvesribeiro self-assigned this May 29, 2018
@galvesribeiro galvesribeiro added the enhancement New feature or request label May 29, 2018
@celluj34
Copy link
Contributor

celluj34 commented Nov 23, 2019

First one can be checked off now, right?

The second one can too, now that the implementations are marked internal.

@smartprogrammer93
Copy link

Please update the README.md file to reflect these changes

@celluj34
Copy link
Contributor

celluj34 commented Dec 4, 2019

Done! Have a look at #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants