Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should molecules with overhangs be allowed to be circular? #149

Open
manulera opened this issue Nov 10, 2023 · 2 comments
Open

Should molecules with overhangs be allowed to be circular? #149

manulera opened this issue Nov 10, 2023 · 2 comments
Labels

Comments

@manulera
Copy link
Collaborator

Hi @BjornFJohansson. I was working on the previous issue when I realise you can create a sequence like this:

from pydna.dseq import Dseq

a = Dseq(watson='AAAA', crick='TTTTG', circular=True)
print(a.__repr__())
print(a.circular)

Returns:

Dseq(o5)
 AAAA
GTTTT
True

Is there a use-case for this type of sequence to be allowed?

@BjornFJohansson
Copy link
Owner

Hi, I used to have lots of sanity checks in the init functions but I removed them to speed things up.
My rationale was that Dseq objects (for my use cases) were almost never made by hand.
This is open to change though.

@manulera
Copy link
Collaborator Author

Yes, that makes sense, there is probably no need to be stringent about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants