{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":89913655,"defaultBranch":"master","name":"bitcoin-abc","ownerLogin":"Bitcoin-ABC","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-05-01T09:58:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/28255313?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714553524.0","currentOid":""},"activityList":{"items":[{"before":"fe7f869a3c96d7205028ff65c86c81de3938f280","after":"893e80e4a44a844854a885dbabf46e18fdc15576","ref":"refs/heads/master","pushedAt":"2024-05-06T17:27:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[chronik-client] Support lokad id endpoints\n\nSummary: Support new lokad id endpoints for chronik instances that index them\n\nTest Plan: CI\n\nReviewers: #bitcoin_abc, tobias_ruck\n\nReviewed By: #bitcoin_abc, tobias_ruck\n\nSubscribers: Fabien, tobias_ruck, emack\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16088","shortMessageHtmlLink":"[chronik-client] Support lokad id endpoints"}},{"before":"6a3a49d8d2a8b11957feae7088838ae75a765ac5","after":"fe7f869a3c96d7205028ff65c86c81de3938f280","ref":"refs/heads/master","pushedAt":"2024-05-06T14:16:36.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"Decouple ChainParams from ArgsManager, add factory functions\n\nSummary:\nChain params can now be initialized by configuring a ChainOptions struct. This offers an interface for\ncreating ChainParams without a gArgs object.\n\nThe factory functions can also easily be used from a context without an instantiated ArgsManager, e.g. from libbitcoin kernel code, unlike the existing CreateChainParams method.\n\nInspired by:\nhttps://github.com/bitcoin/bitcoin/pull/13311/commits/6fa901fb4726ddac025d5396ecf09d047a8aa9a1 (make globalChainParams `const`)\nhttps://github.com/bitcoin/bitcoin/pull/20004/commits/fa23308e9aad70c99a31f91d8556f1876ea02c04 (Remove gArgs global from CreateChainParams)\nhttps://github.com/bitcoin/bitcoin/pull/26177/commits/84b85786f0f5cb23cc257a4464ae345e1d372313 (Decouple ChainParams from ArgsManager)\nhttps://github.com/bitcoin/bitcoin/pull/26177/commits/edabbc78a3bc272b2b802e1dbab73d6ed8e31e96 (Add factory functions for Main/Test/Reg chainparams)\n\nThe main difference with the source material is that we need the ArgsManager for all chains, because of the `-ecash` arg.\n\nTest Plan: `ninja all check-all bitcoin-fuzzers`\n\nReviewers: #bitcoin_abc, Fabien\n\nReviewed By: #bitcoin_abc, Fabien\n\nSubscribers: Fabien\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16114","shortMessageHtmlLink":"Decouple ChainParams from ArgsManager, add factory functions"}},{"before":"22f5560fd2f628f11fe1cdb74d81971331426f5a","after":"6a3a49d8d2a8b11957feae7088838ae75a765ac5","ref":"refs/heads/master","pushedAt":"2024-05-06T13:47:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[ecash-herald] back out avalanche peername\n\nSummary: This was never properly implemented and became too low priority to update the API. Now the endpoint always throws errors. Back out the feature.\n\nTest Plan: `npm test`\n\nReviewers: #bitcoin_abc, Fabien\n\nReviewed By: #bitcoin_abc, Fabien\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16118","shortMessageHtmlLink":"[ecash-herald] back out avalanche peername"}},{"before":"d6f7cb05623c2bff443e3179d1c248f4efa10801","after":"22f5560fd2f628f11fe1cdb74d81971331426f5a","ref":"refs/heads/master","pushedAt":"2024-05-06T11:55:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`\n\nSummary:\nIt is not obvious that CheckSequenceLocksAtTip() function can modify its LockPoints* lp parameter which leads to bugs such as https://github.com/bitcoin/bitcoin/pull/22677#discussion_r762040101 (bug avoided in D12441 by squashing the fix with the commit introducing it)\n\nThis is a backport of [[https://github.com/bitcoin/bitcoin/pull/23897 | core#23897]]\n\nNotes:\n - that this codebase has a single call site for `CheckSequenceLocksAtTip` in `PreChecks`. This is called via `AcceptToMemoryPool` in `DisconnectedBlockTransactions::updateMempoolForReorg`, so we don't have to deal with the code duplication in Core's `Chainstate::MaybeUpdateMempoolForReorg` function\n - this codebase no longer has the `LockPoint::maxInputBlock` computation code (see D15788)\n\nTest Plan: `ninja all check-all`\n\nReviewers: #bitcoin_abc, Fabien\n\nReviewed By: #bitcoin_abc, Fabien\n\nSubscribers: Fabien\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16104","shortMessageHtmlLink":"refactor: Move calculation logic out from <code>CheckSequenceLocksAtTip()</code>"}},{"before":"2f1ee1dd98baaaabf2683c693035d5a9f0d02bad","after":"d6f7cb05623c2bff443e3179d1c248f4efa10801","ref":"refs/heads/master","pushedAt":"2024-05-06T11:36:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[guix] Better SHA256SUMS format\n\nSummary: This formats the output hashes the way we deploy it for the release, which makes it easier and less error-prone.\n\nTest Plan: Run the GUIX builds and check the formatting.\n\nReviewers: #bitcoin_abc, PiRK\n\nReviewed By: #bitcoin_abc, PiRK\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16115","shortMessageHtmlLink":"[guix] Better SHA256SUMS format"}},{"before":"36c765ff3585ae997d703d5064061f10b1ef32ef","after":"2f1ee1dd98baaaabf2683c693035d5a9f0d02bad","ref":"refs/heads/master","pushedAt":"2024-05-06T03:18:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Cashtab] word-break fix for tokens with very long names\n\nSummary: Add `word-break: break-all` for elements that may display token name\n\nTest Plan:\n`npm test`\n\nno overflow for long token names:\n{F7583656}\n\nReviewers: #bitcoin_abc, emack\n\nReviewed By: #bitcoin_abc, emack\n\nSubscribers: emack\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16113","shortMessageHtmlLink":"[Cashtab] word-break fix for tokens with very long names"}},{"before":"3b2044075c3d1cf47506e893a36b084052d80c0b","after":"36c765ff3585ae997d703d5064061f10b1ef32ef","ref":"refs/heads/master","pushedAt":"2024-05-05T21:22:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Automated] Update seeds","shortMessageHtmlLink":"[Automated] Update seeds"}},{"before":"600309e6b44da0b3500a5fdaa9fca34c0d625139","after":"3b2044075c3d1cf47506e893a36b084052d80c0b","ref":"refs/heads/master","pushedAt":"2024-05-05T21:10:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Automated] Update chainparams","shortMessageHtmlLink":"[Automated] Update chainparams"}},{"before":"8f74e2ff94d2dd7268a3cd072fd05a76661c3648","after":"600309e6b44da0b3500a5fdaa9fca34c0d625139","ref":"refs/heads/master","pushedAt":"2024-05-05T20:38:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Automated] Update timing.json","shortMessageHtmlLink":"[Automated] Update timing.json"}},{"before":"7bc682f5d5e1a8f54bb098f7562d2973d5b20bed","after":"8f74e2ff94d2dd7268a3cd072fd05a76661c3648","ref":"refs/heads/master","pushedAt":"2024-05-04T22:07:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[ecash-lib] \"module\": \"CommonJS\" + separate \"main\" and \"browser\"\n\nSummary:\nCurrently, integrating `ecash-lib` into CashTab is very difficult, due to the different environments between jest and webpack:\n- Jest can't handle ES modules, and either fails to import ecash-lib altogether (as it is a module), or, if we change it to be a CommonJS compatible, the generated JS from wasm-bindgen breaks it as `import.meta.url` can't be used, even if it's never executed.\n- Webpack can't find `node:fs/promises`, even though it's lazily loaded and never actually imported.\n\nwasm-bindgen can build ffi modules that work for either NodeJS or web, but it can't build one for both.\nThe simplest solution is to build both use the \"main\" and \"browser\" fields in package.json, and to have two different index files for both, one `indexBrowser.ts` for the browser, and one `indexNodeJs.ts` for NodeJS.\n\nAlso, jest is having issues with ECMAScript Modules (ESM), so we switch to `\"module\": \"CommonJS\"` in tsconfig.json, which will improve overall compatibility of this package.\n\nWe now have two init files, which dynamically switch the Ecc (renamed from EccWasm) and the hash functions out with the one for the correct target.\n\nThis makes it such that the library is still easy to use; the only function a user has to call is `initWasm` to load the WebAssembly, and NodeJS / webpack will pick the right module to load.\n\nThis diff has been shown to work on NodeJS, jest and webpack, and we could successfully integrate it into CashTab, see D16109.\n\nTest Plan: `npm run build`\n\nReviewers: #bitcoin_abc, bytesofman\n\nReviewed By: #bitcoin_abc, bytesofman\n\nSubscribers: bytesofman\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16107","shortMessageHtmlLink":"[ecash-lib] \"module\": \"CommonJS\" + separate \"main\" and \"browser\""}},{"before":"af063fb465f2ca2c0bc99e074979246008b28199","after":"7bc682f5d5e1a8f54bb098f7562d2973d5b20bed","ref":"refs/heads/master","pushedAt":"2024-05-04T03:31:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[e.cash] Fix mobile video display issue\n\nSummary:\nSome users are seeing the background video jump to full screen on mobile causing bad UX and sometimes a blank screen effect.\nFor example on /build, /roadmap, /get-ecash\nIt seems to be unique to iOS safari which has an autoplay fullscreen feature in it apparently\nEven setting the video to display none the issue persisted, so opting to conditionally render the video based on screen size and show a still frame on mobile\nThe video playback speed is a relic of the stealthmode theme, and the ref was causing some issues here when conditionally rendering so also taking that out here\n\nTest Plan: Preview the site and check some subpages out to see if any display issues happen on mobile\n\nReviewers: #bitcoin_abc, bytesofman\n\nReviewed By: #bitcoin_abc, bytesofman\n\nSubscribers: bytesofman\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16110","shortMessageHtmlLink":"[e.cash] Fix mobile video display issue"}},{"before":"335598bb616c23066007eab1dc2990051a24a3c7","after":"af063fb465f2ca2c0bc99e074979246008b28199","ref":"refs/heads/master","pushedAt":"2024-05-03T14:13:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[chronik-client] Add noban permission to cut p2p delays in the websocket test\n\nSummary: This will avoid spurious timeouts when getdata delay triggers during the test.\n\nTest Plan:\n  npm run integration-tests\n\nReviewers: #bitcoin_abc, PiRK\n\nReviewed By: #bitcoin_abc, PiRK\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16103","shortMessageHtmlLink":"[chronik-client] Add noban permission to cut p2p delays in the websoc…"}},{"before":"ef56c603f71c6df7eec433fe2bfcddf2c7fb6406","after":"335598bb616c23066007eab1dc2990051a24a3c7","ref":"refs/heads/master","pushedAt":"2024-05-03T09:37:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"Bump version to 0.29.4\n\nSummary: As per title\n\nTest Plan: `ninja print-version`\n\nReviewers: #bitcoin_abc, Fabien\n\nReviewed By: #bitcoin_abc, Fabien\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16101","shortMessageHtmlLink":"Bump version to 0.29.4"}},{"before":"7d2f38d2cad8676b29c693b9ba2dcf6043970b12","after":"ef56c603f71c6df7eec433fe2bfcddf2c7fb6406","ref":"refs/heads/master","pushedAt":"2024-05-03T08:38:36.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"refactor, validation: Add ChainstateManagerOpts db options\n\nSummary:\nUse ChainstateManagerOpts struct to remove ArgsManager uses from validation.cpp.\n\nThis commit does not change behavior.\n\nThis concludes backport of [[https://github.com/bitcoin/bitcoin/pull/25862 | core#25862]]\nhttps://github.com/bitcoin/bitcoin/pull/25862/commits/aadd7c5b9b43a38beaa954b4cb8c2fff55f2200f\n\nDepends on D16093\n\nTest Plan:\n```\ncmake .. -GNinja -DBUILD_BITCOIN_CHAINSTATE=ON\nninja all check-all\n```\n\nReviewers: #bitcoin_abc, Fabien\n\nReviewed By: #bitcoin_abc, Fabien\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16094","shortMessageHtmlLink":"refactor, validation: Add ChainstateManagerOpts db options"}},{"before":"c2159fe23a34ba0d4b21f4d6be14fc57a648dd70","after":"7d2f38d2cad8676b29c693b9ba2dcf6043970b12","ref":"refs/heads/master","pushedAt":"2024-05-03T01:13:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[ecash-agora] Add `AgoraOneshot`\n\nSummary:\nThis is a simplified Agora offer which can only be accepted in \"one shot\", e.g. all or nothing. This is useful for offers that offer exactly one token, especially NFTs.\n\nThe covenant is reasonably simple, see [[ https://read.cash/@pein/bch-covenants-with-spedn-4a980ed3 | this article ]] for an explanation of the covenant mechanism, but uses two optimizations:\n1. It uses ANYONECANPAY as sighash for the \"accept\" path, which makes the sighash preimage start with `2000....00000`, which can be created with `OP_2 68 OP_NUM2BIN`, saving around 64 bytes.\n2. It uses OP_CODESEPARATOR before the OP_CHECKSIG, which cuts out the entire script code, leaving only the OP_CHECKSIG behind. The scriptCode part in the BIP143 sighash now just becomes `01ac`, which is both easier to deal with in the OP_SPLIT and also saves 100 bytes or so (depending on the enforced outputs).\n\nNote: This currently doesn't add any functionality for discovering trades on the blockchain, which will be done in a future diff.\n\nDepends on D16081.\n\nTest Plan:\n`BUILD_DIR=../../build npm run integration-tests`\n\n# For understanding the covenant:\n1. Install [[ https://github.com/gcash/meep | meep ]]\n2. Run the accept tx of the final tx to see how it works in meep (ignore the buggy sig density check of meep):\n```\n~/meep/bin/go debug -t\n01000000021f236483a002f7613f13da431e08ef6297350969ad1d2522766789b6a68d198801000000fd95012102466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f2740e1d5d9bb0b6e4ca21db777709863933706be84057b36a4f6225ce4ceaaf925044531e9c694ed850d2a010cd882fa0ec4ed1fddeae8661aa5ede1a09fea829bcd4c5a1f236483a002f7613f13da431e08ef6297350969ad1d2522766789b6a68d19880100000001ac2202000000000000ffffffff4fae5c27fc0ba6b8fdf7bc7fe8a6f135c5821bb1f79c275f5554d9d8b8bbe70900000000c10000002222020000000000001976a914531260aa2a199e228c537dfa42c82bea2c7c1f4d88ac514cb0634c6b0000000000000000406a04534c500001410453454e4420da400de527913c3bac117ef8dcc01c05439e9ebea95fe4cd339757ddf3206c9808000000000000000008000000000000000180380100000000001976a914fc7250a211deddc70ee5a2738de5f07817351cef88ac7c7eaa7801327f7701207f7588510144807c7ea86f7bbb7501c17e7c6721034f355bdcb7cc0af728ef3cceb9615d90684bb5b2ca5f859ab0f0b704075871aa68abacffffffff9f968972c1dce000a0d0c4fe781431df265117fdfec6bc4f39333f90df5bab25000000006441d1375981ee3e3e7fece31bc6cd2e5efe26ee5a082cfcd28ce3b97490ae4e3e66d4d9a79cb2eeabe92404ed20943e883e4974e658409e6c390fceee17b72b3b08412102466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27ffffffff030000000000000000406a04534c500001410453454e4420da400de527913c3bac117ef8dcc01c05439e9ebea95fe4cd339757ddf3206c9808000000000000000008000000000000000180380100000000001976a914fc7250a211deddc70ee5a2738de5f07817351cef88ac22020000000000001976a914531260aa2a199e228c537dfa42c82bea2c7c1f4d88ac00000000\n-a 546 -s a9147d5915e36b8635a96aeba1698ce031f9be8e9d4687\n```\n\n# Markdown\nUse https://markdownlivepreview.com/ to make sure it looks good\n\nReviewers: bytesofman, #bitcoin_abc\n\nReviewed By: bytesofman, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16087","shortMessageHtmlLink":"[ecash-agora] Add <code>AgoraOneshot</code>"}},{"before":"6602f525cd0f2870d827b61b0045983adc0712be","after":"c2159fe23a34ba0d4b21f4d6be14fc57a648dd70","ref":"refs/heads/master","pushedAt":"2024-05-02T20:01:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[chronik-client] Make sure we have a listener attached when emitting the ready status event\n\nSummary:\nOtherwise wait for a bit and retry in a loop. Mocha will eventually time out if no listener is ever attached. Also do the same for ecash-lib.\n\nThis will fix most of the integration test failures.\n\nTest Plan:\n  npm run integration-tests\n\nReviewers: #bitcoin_abc, bytesofman\n\nReviewed By: #bitcoin_abc, bytesofman\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16095","shortMessageHtmlLink":"[chronik-client] Make sure we have a listener attached when emitting …"}},{"before":"33fc32118f7779bbe8eac1ddd49dd73410d50447","after":"6602f525cd0f2870d827b61b0045983adc0712be","ref":"refs/heads/master","pushedAt":"2024-05-02T12:01:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Automated] Update seeds","shortMessageHtmlLink":"[Automated] Update seeds"}},{"before":"dd71a6200d4511d56eb6544a5122a4763f50985f","after":"33fc32118f7779bbe8eac1ddd49dd73410d50447","ref":"refs/heads/master","pushedAt":"2024-05-02T06:04:17.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"log: mempool: log removal reason in validation interface\n\nSummary:\nCurrently the exact reason a transaction is removed from the mempool isn't\nlogged. It is sometimes detectable from context, but adding the `reason` to\nthe validation interface logs (where it is already passed) seems like an easy\nway to disambiguate.\n\nFor example, in the case of mempool expiry, the logs look like this:\n\n```\n[validationinterface.cpp:220] [TransactionRemovedFromMempool] [validation] Enqueuing TransactionRemovedFromMempool: txid=<txid>\n[txmempool.cpp:1050] [RemoveUnbroadcastTx] [mempool] Removed <txid> from set of unbroadcast txns before confirmation that txn was sent out\n[validationinterface.cpp:220] [operator()] [validation] TransactionRemovedFromMempool: txid=<txid>\n[validation.cpp:267] [LimitSize] [mempool] Expired 1 transactions from the memory pool\n```\n\nThere is no context-free way to know $txid was evicted on the basis of expiry.\nThis change will make that case (and probably others) clear.\n\nThis is a backport of [[https://github.com/bitcoin/bitcoin/pull/26419 | core#26419]]\nDepends on D16084\n\nTest Plan: `ninja all check-all`\n\nReviewers: #bitcoin_abc, Fabien\n\nReviewed By: #bitcoin_abc, Fabien\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16085","shortMessageHtmlLink":"log: mempool: log removal reason in validation interface"}},{"before":"e21337ab96f77996bad04f3f8e74559cbbe5270d","after":"dd71a6200d4511d56eb6544a5122a4763f50985f","ref":"refs/heads/master","pushedAt":"2024-05-01T15:29:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[ecash-lib] Set the default tx version to 2\n\nSummary: The default tx version in the bitcoind node is 2, CashTab uses version 2, so we should default to version 2 in ecash-lib too.\n\nTest Plan: `npm run test && BUILD_DIR=../../build npm run integration-tests && npm run build`\n\nReviewers: bytesofman, #bitcoin_abc, Fabien\n\nReviewed By: #bitcoin_abc, Fabien\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16090","shortMessageHtmlLink":"[ecash-lib] Set the default tx version to 2"}},{"before":"2c1f37ee6d761889b1715e3f07cbc4d2e66bd492","after":"e21337ab96f77996bad04f3f8e74559cbbe5270d","ref":"refs/heads/master","pushedAt":"2024-05-01T11:38:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"Fix an off by one index error in makeseeds.py\n\nSummary: Each line of the dnsseed.dump contains at least 12 items so we assert the length then access indexes 0 to 11. The assertion is off by one.\n\nTest Plan: Run the makeseeds.py against a dnsseed.dump that is missing the user agent string and check it doesn't crash.\n\nReviewers: #bitcoin_abc, PiRK\n\nReviewed By: #bitcoin_abc, PiRK\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16089","shortMessageHtmlLink":"Fix an off by one index error in makeseeds.py"}},{"before":"3dc2f5f9f3de547fd9beb80546b7fec64003a5bb","after":"2c1f37ee6d761889b1715e3f07cbc4d2e66bd492","ref":"refs/heads/master","pushedAt":"2024-05-01T00:04:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[ecash-lib] Add SLP support\n\nSummary:\nAdds SLP support to ecash-lib for all the token types supported by Chronik (Fungible, Mint Vault, NFT1 Group, NFT1 Child).\n\nMint Vault tokens require us to mine in tests, so we add the `'generate'` cmd to `SetupFramework`.\n\nTest Plan: `npm run integration-tests`\n\nReviewers: bytesofman, #bitcoin_abc\n\nReviewed By: bytesofman, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16081","shortMessageHtmlLink":"[ecash-lib] Add SLP support"}},{"before":"93eb3a339e2388d40fef5f76fad42d66c1260ec2","after":"3dc2f5f9f3de547fd9beb80546b7fec64003a5bb","ref":"refs/heads/master","pushedAt":"2024-04-30T22:14:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Automated] Update electrum checkpoints","shortMessageHtmlLink":"[Automated] Update electrum checkpoints"}},{"before":"3e94659b91f0992949f5fe96cb9fcc86bcf815c8","after":"93eb3a339e2388d40fef5f76fad42d66c1260ec2","ref":"refs/heads/master","pushedAt":"2024-04-30T19:09:27.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[integration tests] Don't override the ipc timeout\n\nSummary: The IPC timeout was overriden when introduced to demonstrate the API for the integration tests, but since then this has been copy pasted everywhere with no apparent thought. Remove it and use the default to avoid test timeouts.\n\nTest Plan:\n  ./contrib/teamcity/build-configurations.py chronik-client-integration-tests\n  ./contrib/teamcity/build-configurations.py ecash-lib-integration-tests # Note this doesn't run on my machine\n\nReviewers: #bitcoin_abc, PiRK\n\nReviewed By: #bitcoin_abc, PiRK\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16083","shortMessageHtmlLink":"[integration tests] Don't override the ipc timeout"}},{"before":"9ca3785dbd583b8b0f7106661277740756699c4b","after":"3e94659b91f0992949f5fe96cb9fcc86bcf815c8","ref":"refs/heads/master","pushedAt":"2024-04-30T15:52:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"Add release notes for Chronik's LOKAD ID index\n\nSummary: Release notes for the new LOKAD ID index. Since it's enabled by default, it's important to highlight how users can avoid reindexing it for hours.\n\nTest Plan: Copy into https://markdownlivepreview.com/\n\nReviewers: Fabien, #bitcoin_abc\n\nReviewed By: Fabien, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16086","shortMessageHtmlLink":"Add release notes for Chronik's LOKAD ID index"}},{"before":"15b0788f25c2fcdcb1a4f907af33505accd8ce85","after":"9ca3785dbd583b8b0f7106661277740756699c4b","ref":"refs/heads/master","pushedAt":"2024-04-30T15:36:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Chronik] Add `-chronikcors`\n\nSummary:\nCurrently, if someone wants to use Chronik from a browser, they have to add an intermediary reverse proxy like NGINX (see [[ https://chronik-doc.fabien.cash/chronik-setup/host-chronik | here ]]).\n\nThis adds the hidden `-chronikcors` flag, which allows users to connect to their instance directly (e.g. on localhost) without having to run a reverse proxy adding the CORS headers.\n\nOne example of this would be an app dev that wants to run a regtest instance locally and connect their webapp to that local regtest instance to try it out. Currently, this would throw CORS errors in all browsers with no mechanism to disable it in the browser, and devs would have to add a proxy locally to add those headers.\n\nThe option is hidden because we don't want users to enable it without care, as Chronik is intended to be run behind a reverse proxy (to e.g. add HTTPS or enforce rate limits).\n\nTest Plan: `./test/functional/test_runner.py chronik_cors.py`\n\nReviewers: Fabien, #bitcoin_abc, PiRK\n\nReviewed By: Fabien, #bitcoin_abc, PiRK\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16077","shortMessageHtmlLink":"[Chronik] Add <code>-chronikcors</code>"}},{"before":"74d647d0b05cc0ed74ba2445fb73edd9bd2f7660","after":"15b0788f25c2fcdcb1a4f907af33505accd8ce85","ref":"refs/heads/master","pushedAt":"2024-04-30T13:57:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Cashtab] Add support for Malaysian Ringgit\n\nSummary:\nAdd support for setting foreign currency to MYR\n\nT3562\n\nTest Plan:\nProofread to confirm correct ticker and symbol. `npm start` and confirm price makes sense.\n\n{F7552966}\n{F7552967}\n{F7552969}\n\nReviewers: #bitcoin_abc, emack\n\nReviewed By: #bitcoin_abc, emack\n\nSubscribers: emack\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16076","shortMessageHtmlLink":"[Cashtab] Add support for Malaysian Ringgit"}},{"before":"91020cd9d3668ef2eb4fd27c1ded443ba999d680","after":"74d647d0b05cc0ed74ba2445fb73edd9bd2f7660","ref":"refs/heads/master","pushedAt":"2024-04-30T13:17:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Cashtab] Patch bug caused by wallet change from Tokens page\n\nSummary:\nThe screen defines `tokens` as `wallet.state.tokens` in one place, uses this value to do the calculations, but then triggers the useEffect on `wallet.state.tokens`.\n\nMake sure the `tokens` used in the `useEffect` is the same `tokens` used in the dependency array.\n\nTest Plan: `npm test`, `npm start`, navigate to tokens page, change wallets a few times, no white screen app crash\n\nReviewers: #bitcoin_abc, PiRK\n\nReviewed By: #bitcoin_abc, PiRK\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16078","shortMessageHtmlLink":"[Cashtab] Patch bug caused by wallet change from Tokens page"}},{"before":"17e17ba21d0ba776a40be63bfbde05a6859b6455","after":"91020cd9d3668ef2eb4fd27c1ded443ba999d680","ref":"refs/heads/master","pushedAt":"2024-04-30T13:05:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[Cashtab] Use latest chronik-client\n\nSummary: Upgrade chronik-client so we get `timeFirstSeen` as a number and not a string\n\nTest Plan: `npm test`\n\nReviewers: #bitcoin_abc, emack\n\nReviewed By: #bitcoin_abc, emack\n\nSubscribers: emack\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16065","shortMessageHtmlLink":"[Cashtab] Use latest chronik-client"}},{"before":"7346f3b475cb2b73bce5c7ca1dca449eb5070141","after":"17e17ba21d0ba776a40be63bfbde05a6859b6455","ref":"refs/heads/master","pushedAt":"2024-04-30T08:22:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"Bypass headers anti-DoS checks for NoBan peers\n\nSummary:\nThis allows you to easily avoid downloading headers twice if you have a trusted node to connect to\n\nThis concludes backport of [[https://github.com/bitcoin/bitcoin/pull/25960 | core#25960]]\nhttps://github.com/bitcoin/bitcoin/pull/25960/commits/e5982ecdc4650e9b6de38f190f3a97d792499e2a\n\nTest Plan: `ninja all check-all`\n\nReviewers: #bitcoin_abc, Fabien\n\nReviewed By: #bitcoin_abc, Fabien\n\nSubscribers: Fabien\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16075","shortMessageHtmlLink":"Bypass headers anti-DoS checks for NoBan peers"}},{"before":"a1e137d5e8ebe6bfab2d4e9457975bec623ba3ef","after":"7346f3b475cb2b73bce5c7ca1dca449eb5070141","ref":"refs/heads/master","pushedAt":"2024-04-30T03:53:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Fabcien","name":"Fabien","path":"/Fabcien","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44533924?s=80&v=4"},"commit":{"message":"[e.cash] Add Guarda Wallet back\n\nSummary: Adding guarda wallet back to the wallets page as previous issues have been resolved\n\nTest Plan: preview the site and check the wallets page guarda tile looks good\n\nReviewers: #bitcoin_abc, bytesofman\n\nReviewed By: #bitcoin_abc, bytesofman\n\nSubscribers: bytesofman\n\nDifferential Revision: https://reviews.bitcoinabc.org/D16080","shortMessageHtmlLink":"[e.cash] Add Guarda Wallet back"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQsZsDgA","startCursor":null,"endCursor":null}},"title":"Activity · Bitcoin-ABC/bitcoin-abc"}