New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in secp256k1 PublicKey constructor #805

Open

afk11 opened this issue Oct 22, 2019 · 0 comments · May be fixed by #827

Member

afk11 commented Oct 22, 2019 •

edited

bitcoin-php/src/Crypto/EcAdapter/Impl/Secp256k1/Key/PublicKey.php

Line 42 in 513a3b7

!get_resource_type($secp256k1_pubkey_t) === SECP256K1_TYPE_PUBKEY) {

The negation is performed on the result of get_resource_type($pubkey), not get_resource_type($pubkey) == ...

The text was updated successfully, but these errors were encountered:

afk11 added a commit to afk11/bitcoin-php that referenced this issue


          Fix Bit-Wasp#805: Incorrect tests of resource type

ac08142

afk11 linked a pull request

that will close this issue

Fix #805: Incorrect tests of resource type #827

Open

afk11 added a commit to afk11/bitcoin-php that referenced this issue


          Fix Bit-Wasp#805: Incorrect tests of resource type

1aab3ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment