Add xonsh command syntax to work with xonsh as the default shell #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsh syntax No need to pass a `-p` argument explicitly (though the argument will override autodetection)
|
Thank you for submitting your pull request. I appreciate your contribution and the time you have invested in making this change. However, I am not currently interested in implementing this change. I apologize for any inconvenience this may cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new Python command syntax that can be understood by the Python-based
xonshshell, which is required when xonsh is used as the default shell since it chokes on the currentsh-based syntax:-p/--pythoncommand line argument (but then this breaks other default shells, so inconvenient if you switch default shells)grep "^$(id -un)": /etc/passwdto get the default shell before launching the relevant command) — I've copied your main process creation code and just removed the parts that weren't needed (sockets etc.), so it's a bit of a code duplicationFor the new syntax I bypassed the
appendWslArgfunction as there is no need to escape the quotes, and I don't understand how relevant the other corrections are (and how to adjust them properly for the new syntax) :)Only tested this with
ConEmuandmsys2Fixes: #31