Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange code for GenomicRanges:::compatibleStrand #33

Open
msannell opened this issue Feb 9, 2020 · 1 comment
Open

strange code for GenomicRanges:::compatibleStrand #33

msannell opened this issue Feb 9, 2020 · 1 comment
Assignees

Comments

@msannell
Copy link

msannell commented Feb 9, 2020

Hi. I noticed some strange code in GenomicRanges (v1.38.0) for the
function GenomicRanges:::compatibleStrand. I believe that when
building GenomicRanges in R, the following happens:

  1. R processes strand-utils.R, which defines an S4 generic for
    compatibleStrand stored in GenomicRanges:::compatibleStrand, and
    defines several S4 methods.

  2. R processes findOverlaps-methods.R (this is processed after
    strand-utils.R, according to the "Collate" field in
    GenomicRanges/DESCRIPTION). This file defines a regular function
    stored in GenomicRanges:::compatibleStrand, overwriting the generic
    function defined in strand-utils.R.

Thus, this package defines several methods for compatibleStrand that
are never used, since there is no S4 generic function for it. Was
this intentional? It could be that the generic and methods are just
stale code that should be removed.

@hpages
Copy link
Contributor

hpages commented Feb 14, 2020

yikes! not good. I'll take care of it. Thanks for the catch.

@hpages hpages self-assigned this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants