Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PolySTest #3383

Open
10 tasks done
veitveit opened this issue Mar 29, 2024 · 8 comments
Open
10 tasks done

Add PolySTest #3383

veitveit opened this issue Mar 29, 2024 · 8 comments
Labels
OK pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean

Comments

@veitveit
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @veitveit

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: PolySTest
Title: PolySTest: Detection of differentially regulated features. Combined 
      statistical testing for data with few replicates and missing values
Version: 0.99.0
Authors@R: 
    person("Veit", "Schwämmle", , "veits@bmb.sdu.dk", role = c("aut", "cre"),
 comment = c(ORCID = "0000-0002-9708-6722"))
Description: The complexity of high-throughput quantitative omics
   experiments often leads to low replicates numbers and 
   many missing values. We implemented a new test to simultaneously 
   consider missing values and quantitative changes, which we combined
   with well-performing statistical tests for high confidence
   detection of differentially regulated features. The package contains
   functions to run the test and to visualize the results.
License: GPL-2
Encoding: UTF-8
biocViews: MassSpectrometry, Proteomics, Software, DifferentialExpression
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.1
Imports:
    fdrtool (>= 1.2.15),
    limma (>= 3.44.3),
    matrixStats (>= 0.57.0),
    qvalue (>= 2.22.0),
    shiny (>= 1.5.0),
    SummarizedExperiment (>= 1.20.0),
    knitr (>= 1.33),
    plotly (>= 4.9.4),
    heatmaply (>= 1.1.1),
    circlize (>= 0.4.12),
    UpSetR (>= 1.4.0),
    gplots (>= 3.1.1),
    S4Vectors (>= 0.30.0),
    parallel (>= 4.1.0),
    grDevices (>= 4.1.0),
    graphics (>= 4.1.0),
    stats (>= 4.1.0),
    utils (>= 4.1.0)
Suggests: 
    testthat (>= 3.0.0)
VignetteBuilder: knitr
Config/testthat/edition: 3
Depends: 
    R (>= 4.3.0)

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Mar 29, 2024
@lshep lshep added Post Release Deadline package submitted after posted deadline. reviewer will only review if time allows 3e. pending pre-review changes review has indicated blocking concern that needs attention labels Apr 4, 2024
@lshep
Copy link
Contributor

lshep commented Apr 4, 2024

  • Is it possible to move the Dockerfile and bitbucket-pipelines.yml and bioconda installation stuff to a different branch so that a clean R packages is submitted and distributed by Bioconductor

  • The citation file is currently malformed

> readCitationFile("CITATION")
Error in tools:::.parse_CITATION_file(file, meta$Encoding) : 
  non-ASCII input in a CITATION file without a declared encoding
  • Please include an inst/scripts that has a file that describes how the data in inst/extdata was generated. It can be text, psuedo-code, or code but should contain any relevant source and licensing information.

  • Rplots.pdf in the top level directory should be removed

@veitveit
Copy link
Author

veitveit commented Apr 6, 2024

Thank you @lshep

I would prefer to keep docker file and bioconda files to avoid having to simultaneously maintain multiple branches. I moved everything to the inst folder. Would that be fine?

  • The citation file should be fine now

  • script file about data set has been added

  • Rplots.pdf has been removed

@lshep lshep removed the Post Release Deadline package submitted after posted deadline. reviewer will only review if time allows label May 9, 2024
@lshep lshep added pre-check passed pre-review performed and ready to be added to git and removed 3e. pending pre-review changes review has indicated blocking concern that needs attention labels May 17, 2024
@lshep
Copy link
Contributor

lshep commented May 17, 2024

FWIW: I still get the following

> readCitationFile("CITATION")
Error in tools:::.parse_CITATION_file(file, meta$Encoding) : 
  non-ASCII input in a CITATION file without a declared encoding

tools::showNonASCII(readLines("CITATION"))
5: author="Veit Schwmmle, Christian E. Hagensen, Adelina Rogowska-Wrzesinska, Ole N. Jensen",
14: author="Veit Schwmmle",

@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels May 17, 2024
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 22.04.3 LTS): PolySTest_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/PolySTest to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 9b49c8d09f23b86a3b46d8c6bb0818e84d7ef850

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 22.04.3 LTS): PolySTest_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/PolySTest to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OK pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean
Projects
None yet
Development

No branches or pull requests

3 participants