Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postfixadmin version differs #49

Open
erdoking opened this issue Jun 3, 2019 · 2 comments
Open

postfixadmin version differs #49

erdoking opened this issue Jun 3, 2019 · 2 comments

Comments

@erdoking
Copy link

erdoking commented Jun 3, 2019

You wrote in your readme
"Postfixadmin 2.3.6 is downloaded from Sourceforge"

but if i look into the quellcode: (Debian Stretch)

my $postfixadminURL = "https://netcologne.dl.sourceforge.net/project/postfixadmin/postfixadmin/postfixadmin-3.0.2/postfixadmin-3.0.2.tar.gz";
my $postfixadminURL = 'https://downloads.sourceforge.net/project/postfixadmin/postfixadmin/postfixadmin-3.1/postfixadmin-3.1.tar.gz';

Newest version: 3.2

This looks confusing ;)

maybe you just want to download the newest version?
https://sourceforge.net/projects/postfixadmin/files/latest/download

@jpptinsley
Copy link
Contributor

Trouble with downloading the 'latest' version is that sometimes they make changes that break the installer, as they did with the setup password complexity requirements

@BigRedS
Copy link
Owner

BigRedS commented Jun 28, 2020

Yeah, the other issue is that to track 'latest' requires parsing the sourceforge page to figure out what that is. There might be a better way now theyr'e on Github, too.

I think tracking an idea of 'latest' would be a good idea, but that's a different problem to not actually installing the version claimed!

I'm going to fix this for now by not making that claim in the readme doc, and also fix up the code to be less confusing. Tracking latest can be a problem for another day.

BigRedS pushed a commit that referenced this issue Jun 28, 2020
I read the script for the first time in a _long_ time and made some
changes. Ones that hit issues include:

* Fixes #49 in a way by only setting $postfixadminURL once, and getting the
  version right in the README. #50 can track figuring out how to always use
  the latest PFA

* Fixes #46 by assuming socket-based auth in mariadb if there's no
  password in the debian.cnf; this is probably always the case in Buster.

* Fixes #43 by minding less about mariadb packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants