Confusing runForAll and runIndependent Events

[k-jiang]

runForAll runs Events as all online players only. Shouldn't we call it runAsAllOnlinePlayer instead?

runIndependent actually runs static Events as Scheduler does. It is better to be called runAsScheduler.

[k-jiang]

My two cents: A lot of Events are not designed for "for all online player" or "Scheduler" situation. Like, command, lightning, score, folder:

• It is puzzling to think about "Set the weather to rain on every players with a 'world:' parameter": Does the rain still going on if the player stand on a different world?
• "Why I can only remove tags for offline player, but not add. How about score?"

Personally speaking most of events should be considered case by case. e.g.

• Prevent static Events like "weather" to be run as player.
• For tag etc, add new parameters like "scope:online" or "scope:offline" on static events directly. The event itself determine and implement different logics base on the initiator (who execute it) locally.

[J0B10]

First of all thanks a lot for your suggestion, it helps a lot to get some user perspective to spot what might be causing confusion.

I agree that the names are not optimal, we have already thought of many alternatives but so far we couldn't find a better one.
All proposals so far have either been way to long, hard to read / write or inaccurate.
From how often you edited your post I assume that it was hard for you too, to come up with a fitting one.
We'll continue that discussion and consider your suggestions.

Regarding your second comment:
I personally think that a lot of that confusion occurs because this is barely documented for most of the events and that some implementations are just inconsistent. We'll have to review each event to streamline them more and make it more clear how they behave. We already startet fixing some larger issues regarding command, killmob and spawn but this will be a ton of work.

Regarding your concrete bullet points:

• rain will start in the given world. if no world is given rain starts in the players world. If run independent / from a schedule a world must be given. Is it really that confusing? Or is just the documentation bad?
• It's bad that you cannot add tags for all players. It was done this way due to performance concerns, but we plan to add this in the future. Same for objectives, points, journals, ...
• Sometimes you might wanna change weather only in the players world, so preventing this would break existing functionality
• Defining scopes is something we are discussing. We also discussed the possibility to separate this into different events, for example tag (only on one player) and tagall (static, for all players in database).

[k-jiang]

Thank you for your reply! Your answer cleared out a lot of confusions for me.

I agree that it is hard to come up with a name that is both informative and short at the same time. However as an user myself, I would prefer clearness more over fast typing. The original naming does not indicate what it does fairly. Some may simply misunderstand by looking at a name like runForAll when you have the other runIndependent that mentioned it would remove all player's tag including offline. It take me over an hour reading through docs and PRs just to understand what they do and the purpose of them.

When achieving both length, speed and accuracy is not possible, I think to have a priority on accuracy would be generally a good idea, especially for events with strict and predefined context. It does not conflict with readability. Users can simply make sense out of it without looking up and docs. And it can also provided the necessary information needed. Which is a must considering most of new comers (or even experts) usually do not have a clear idea on how the system works. If a lot of time could be saved by adding one or two words, then it is definitely a good investment.

And I just find out the suggestion I gave has grammatical error 😂. It should be runOnAllOnlinePlayer and runOnScheduler. Like you said more discussion need to be done and it might not be the perfect choice. But it is way more clear imo.

It also a great idea if the document can mention more details on the differences or use cases. Splitting tag into tagall is awesome. Which is what I was thinking before. I could imagine the amount of works that need to be done with fixing all the issues so tons of thanks for all your efforts.