Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #if to temporarily omit PRIF/Caffeine code using assumed rank #106

Open
bonachea opened this issue Apr 3, 2024 · 0 comments
Open

Add #if to temporarily omit PRIF/Caffeine code using assumed rank #106

bonachea opened this issue Apr 3, 2024 · 0 comments

Comments

@bonachea
Copy link
Member

bonachea commented Apr 3, 2024

flang currently lacks support for assumed-rank dummy arguments like array(..). These are currently required by the following PRIF procedures, and their corresponding Caffeine implementation:

  1. prif_put (non-_raw version only)
  2. prif_get (non-_raw version only)
  3. prif_co_* (all collectives)

This issue suggests creating a temporary (and not officially supported) "dialect" of PRIF and Caffeine, gated by a preprocessor symbol, that entirely omits these features and their corresponding implementation.

To be concrete, this could look something like a -DMISSING_ASSUMED_RANK preprocessor flag added to FPM's C and Fortran flags, and corresponding #if !MISSING_ASSUMED_RANK guards around the declarations and code corresponding to the features above.

Having this in-place should enable us to add flang into CI and test future PRIF PRs submitted against LLVM, which makes this high-priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant