Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple daemons and miners running while daemon is installed as Windows Service #107

Open
ariadarkkkis opened this issue May 1, 2018 · 5 comments

Comments

@ariadarkkkis
Copy link

I use NSSM to create service. I have this problem on some servers that miner crash or something that I don't know, But it will start another daemon because its a service and that service runs daemon. So when miner crashes or pauses or being killed or something like that which I don't know exactly what the problem is, It will restart the service. So the problem is a daemon is already running and I don't know how but service will start again and starts another daemon while the old daemon is still running and runs another miner. but I can close it via task manager because it's not a part of that service anymore. I'm looking for a code inside xmrigCC to allow ONLY 1 xmrigDaemon and 1 xmrigMiner runs at the same time.
I'm using windows and run miner on windows.

@ariadarkkkis
Copy link
Author

anyone?

@chekamarue
Copy link

yeah! that would be great to implement a restriction to allow only 1 instance running for the miner in windows os

@electroape
Copy link

electroape commented Sep 2, 2018

We definitely need that feature (only 1 running instance). And\or automatic miner shutdown if no daemon present, because miner doesn't start on it's own anyway, and new instance of daemon explicitly runs new miner instance even if there's already running one.

Another usecase is using task scheduler to run miner and automatically shutdown it when on battery. Now we will just endup woth multiple miner instances since only daemon will be shutdown.

Or ... why we won't just merge daemon and miner in one binary ?

@ariadarkkkis
Copy link
Author

yea still waiting for @Bendr0id to make some time for it

@Bendr0id
Copy link
Owner

Bendr0id commented Sep 3, 2018

This is not a feature which is wanted by everyone. There are a lot of users which run different miners on the same machine to mine different coins at the same time.

So it has to be a property which can be configured. And it has to be a solution which works for all platforms. But anyways i don't see it as a problem of the miner to keep track that there is only a single instance. It's your bad configured service which is making the trouble, not the miner/daemon. Per definition a windows service is running as a single instance. The only problem i can see is that the miners isn't dieing when the daemon is destroyed. So this is maybe a thing to look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants