Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tails-screen-locker just sort of appears on the screen without any explanation during descriptor importing #57

Closed
BenWestgate opened this issue Jul 27, 2023 · 3 comments · Fixed by #161
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed priority: medium Issues raised by 1 tester question Further information is requested wontfix This will not be worked on
Milestone

Comments

@BenWestgate
Copy link
Owner

This step can be either really fast or slow depending on the blockchain progress and how busy the node is.

I should say more obviously, this will be slow, lock your screen if you have to step away from the computer. BEFORE showing the dialog for tails-screen-locker. Otherwise it just sits there and the notification with explanation expires.

@BenWestgate BenWestgate added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested priority: low Issues raised by only myself labels Jul 27, 2023
@BenWestgate
Copy link
Owner Author

Lets make a file called "remind-lock-screen" that checks if the user has a screen lock passphrase set and notifies them every 3 +/- minutes if not, else clears its notifications and exits. This is for chainstate-preload.

Press the lock screen keys to lock your computer if you need to walk away from it.

@BenWestgate BenWestgate added priority: medium Issues raised by 1 tester and removed priority: low Issues raised by only myself labels Mar 25, 2024
@BenWestgate
Copy link
Owner Author

This also defines the scope of bails-wallet for seed recovery, it should build the descriptor and stop there. (This means in L2, we can also let it display a QR of that descriptor.) That way Bails can offer some entertainment during long steps like descriptor importing, as well as me not need to worry about teaching bails-wallet how to detect and import descriptors.

@BenWestgate BenWestgate added this to the L1 (BETA) milestone Mar 26, 2024
@BenWestgate BenWestgate added the wontfix This will not be worked on label May 26, 2024
@BenWestgate
Copy link
Owner Author

We can't kill notifications anymore. But we do try to set the screen lock password during each boot. If this needs to be reopened we will replace it with a dialog since notifications create spam that reduces privacy on the lock screen.

@BenWestgate BenWestgate linked a pull request May 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed priority: medium Issues raised by 1 tester question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant