Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "limiting block storage to X GB" in my Bitcoin Core Info does not match what is displayed in the GUI. #35

Closed
BenWestgate opened this issue Jul 23, 2023 · 4 comments · Fixed by #124
Closed

The "limiting block storage to X GB" in my Bitcoin Core Info does not match what is displayed in the GUI. #35

BenWestgate opened this issue Jul 23, 2023 · 4 comments · Fixed by #124
Assignees
@BenWestgate
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers priority: high issues raised or encountered by 2 or more testers
Milestone
L1 (BETA)

Comments

@BenWestgate
Copy link
Owner

2 GB matches 2GB but 6GB was displayed in my dialog and 7GB in the Bitcoin Core GUI. This is likely due to an off by 1MiB error or insufficient precision in my conversion between GB and MiB, check bitcoin core's code for converting between the two formats.
@BenWestgate BenWestgate added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 23, 2023
@BenWestgate BenWestgate mentioned this issue Jul 23, 2023
Closed
@BenWestgate BenWestgate added the priority: low Issues raised by only myself label Jul 23, 2023
@github-actions GitHub Actions
Copy link

Stale issue message

@BenWestgate
Copy link
Owner Author

This is a good issue for any new contributor to try.

@BenWestgate
Copy link
Owner Author

BenWestgate commented Mar 30, 2024 •
edited

The best way to fix this is run the command:

HOME+=/Persistent
bitcoin-qt -choosedatadir

This will change the default to match the custom data directory. Only the prune will need to be set to the highest value that doesn't show the warning: available minus 10. This will allow removing the dialog entirely and considerable code.

@BenWestgate BenWestgate added this to the L1 (BETA) milestone Mar 31, 2024
@BenWestgate BenWestgate added priority: high issues raised or encountered by 2 or more testers and removed priority: low Issues raised by only myself labels Apr 1, 2024
@BenWestgate BenWestgate self-assigned this Apr 1, 2024
@BenWestgate
Copy link
Owner Author

Note: the changing of the HOME env variable should be within a background shell not the main process.

@BenWestgate BenWestgate linked a pull request May 14, 2024 that will close this issue
Remove Bitcoin core info dialog & unneeded variables #124
Merged
@BenWestgate BenWestgate mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenWestgate BenWestgate

Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers priority: high issues raised or encountered by 2 or more testers
Projects
None yet
Milestone
L1 (BETA)
Development

Successfully merging a pull request may close this issue.

Remove Bitcoin core info dialog & unneeded variables BenWestgate/Bails
1 participant
@BenWestgate