Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Enter should submit the passphrase + entry field should start focused #111

Closed
BenWestgate opened this issue Mar 26, 2024 · 0 comments · Fixed by #146
Closed

Pressing Enter should submit the passphrase + entry field should start focused #111

BenWestgate opened this issue Mar 26, 2024 · 0 comments · Fixed by #146
Assignees
@BenWestgate
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers priority: medium Issues raised by 1 tester
Milestone
L1 (BETA)

Comments

@BenWestgate
Copy link
Owner

BenWestgate commented Mar 26, 2024 •
edited

Describe the bug
Pressing Enter does not submit the passphrase in the simple dialog.
And the passphrase field should start with focus and not require a click to begin typing it.

To Reproduce
Steps to reproduce the behavior:
Type a passphrase twice and match, OK button becomes sensitive but does not grab focus.

Expected behavior
It should grab focus after a match so pressing Enter submits the passphrase.

Additional context
We will also need to check the strength metered passphrase dialog.
@BenWestgate BenWestgate added bug Something isn't working enhancement New feature or request good first issue Good for newcomers priority: medium Issues raised by 1 tester labels Mar 26, 2024
@BenWestgate BenWestgate added this to the L1 (BETA) milestone Mar 26, 2024
@BenWestgate BenWestgate changed the title Pressing Enter should submit the passphrase Pressing Enter should submit the passphrase + entry field should start focused May 14, 2024
@BenWestgate BenWestgate self-assigned this May 17, 2024
@BenWestgate BenWestgate linked a pull request May 17, 2024 that will close this issue
Passphrase starts with focus, enter submits matched passphrase in set… #146
Merged
@BenWestgate BenWestgate mentioned this issue May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenWestgate BenWestgate

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers priority: medium Issues raised by 1 tester
Projects
None yet
Milestone
L1 (BETA)
Development

Successfully merging a pull request may close this issue.

Passphrase starts with focus, enter submits matched passphrase in set… BenWestgate/Bails
1 participant
@BenWestgate