Display outline values instead of index in junit output #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuf6429
commented
Mar 3, 2024
| } | ||
|
|
||
| Assert::assertEquals(0, $this->getExitCode()); | ||
| Assert::assertEquals(0, $this->getExitCode(), $message); |
There was a problem hiding this comment.
Not related to this PR, but when tests failed, the output was hidden since echo/output is not the right way to influence PHPUnit test results (the $message assertion parameter should be used instead).
uuf6429
commented
Mar 3, 2024
| * @return string | ||
| */ | ||
| private function buildExampleName(ExampleNode $scenario) | ||
| private function buildExampleName(ExampleNode $scenario): string |
There was a problem hiding this comment.
I'm wondering if it would make sense to have this function inside ExampleNode - it might be useful elsewhere.
I have implemented something similar for a custom report at work, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces "example name #N" with "example name (XX)" in JUnit output.
Closes #1448