Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Am I misunderstanding TP_LOCALLAB_AVOIDCOLORSHIFT_TOOLTIP? #7066

Open
marter001 opened this issue May 3, 2024 · 3 comments
Open

Am I misunderstanding TP_LOCALLAB_AVOIDCOLORSHIFT_TOOLTIP? #7066

marter001 opened this issue May 3, 2024 · 3 comments

Comments

@marter001
Copy link
Contributor

In TP_LOCALLAB_AVOIDCOLORSHIFT_TOOLTIP you can read:
….. Lab, applies a gamut control, in relative colorimetric, Munsell is then applied. …..
XYZ Relative, applies gamut control, in relative colorimetric, Munsell is then applied.

Since I don‘t see the difference here, it's difficult to translate.
Any explanation would be appreciated.

@Desmis
Copy link
Collaborator

Desmis commented May 3, 2024

@marter001
It's not the same thing.

In Lab mode, we check if we are not out of gamut, and we apply relative colorimetry (LCH) in Lab mode.

In XYZ mode, the gamut is checked, but the limits and the procedure for doing so are different. Either we correct the gamut in absolute or in relative (XYZ).
The result is not the same as Lab.

Behind we apply the Munsell corection to avoid color drift (oranges, blue/purple, green...).

Jacques

@marter001
Copy link
Contributor Author

@Desmis thanks for the explanation.

What confuses me is the identical wording for different procedures (Lab - relative XYZ).

May be it could be a suggestion to use your explanation above for the tooltip.
In case of not, i suggest to add your last sentence "The result is not the same as Lab" at the end of this tooltip.

For a non native english speaking person, i think, such could be more helpful.

Thanks again

Martin

@Desmis
Copy link
Collaborator

Desmis commented May 4, 2024

@marter001
I'm not an English speaker either. I can add the text you suggest in a future update.

TP_LOCALLAB_AVOIDCOLORSHIFT_TOOLTIP;Fit colors into gamut of the working color space and apply Munsell correction (Uniform Perceptual Lab).
Default: Munsell only.
Munsell only, fixes Lab mode hue drifts due to non-linearity, when chromaticity is changed (Uniform Perceptual Lab).
Lab, applies a gamut control, in relative colorimetric, Munsell is then applied.
XYZ Absolute, applies gamut control, in absolute colorimetric, Munsell is then applied.
XYZ Relative, applies gamut control, in relative colorimetric, Munsell is then applied. The result is not the same as Lab.

Regardless of this modification, I recommend in 95% of cases to use "Munsell only"

Jacques

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants