Fix for crash in dcp.cc #7039
Open
Fix for crash in dcp.cc #7039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stream a C-string of the file name instead of the Glib::ustring. The ustring can throw an exception with certain locale settings and file name character combinations, such as with LANG=es_ES and the character "ä". Only print the message if verbose is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the crash in the linked issue with the environment variable LANG=es_ES and the character "ä" in the file name. Adding a
Glib::ustringcontaining the character to an output stream causes an exception to be thrown. Converting theGlib::ustringinto a C-string fixes the crash and correctly prints the file name.I also made the message only print if verbose mode is enabled.
Fixes #7034.