Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic lens correction via lensfun does not work with Leica-SL2-S and Sigma L-mount lenses, manual selection works #7008

Open
Reiner1959 opened this issue Mar 24, 2024 · 5 comments · May be fixed by #7022
Assignees
Milestone

Comments

@Reiner1959
Copy link

As the title says, automatic lens correction is not working.
Maybe the reason is the missing lens make vendor. As you can see in the screenshot
there is the camera vendor listed under info but no lens maker vendor:

LEICA CAMERA AG LEICA SL2-S + 28 - 70mm F2.8 DG DN | Contemporary 021

But the lens maker is in the exif data:
(see screenshot, right side)

Lens Make SIGMA

I think the complete info string should be:
LEICA CAMERA AG LEICA SL2-S + SIGMA 28 - 70mm F2.8 DG DN | Contemporary 021

Systeminfo:
Rawtherapee 5.10
Debian testing
amd64

best regards
Reiner
Bildschirmfoto vom 2024-03-24 12-29-43

@Lawrence37
Copy link
Collaborator

Can you provide a sample image?

@Reiner1959
Copy link
Author

of course the sample image, from above

A sample image can be found under this link:
https://file.io/VxxkVc3vGMdW
Attention: this file will be automatically deleted after download

If you have a better filesharing resource, please tell :-)

Best regards
Reiner

@Reiner1959
Copy link
Author

And here on fastupload.io

https://fastupload.io/sPWgMkmrOTwcPIM/file

@Lawrence37
Copy link
Collaborator

Thanks, I've downloaded the file. We typically recommend using filebin.net to share files that are too big to attach here directly.

@Lawrence37 Lawrence37 self-assigned this Mar 30, 2024
@Lawrence37 Lawrence37 added this to the v5.11 milestone Mar 30, 2024
@Lawrence37
Copy link
Collaborator

Even with the lens make, Lensfun fails to find the lens. It does work if the lens name does not contain spaces around the dash, i.e. 28-70mm F2.8 DG DN | Contemporary 021 instead of 28 - 70mm F2.8 DG DN | Contemporary 021. I have created a pull request that adds an additional round of lens matching with the spaces around dashes removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants