Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile support #13

Open
vlrevolution opened this issue Sep 10, 2023 · 4 comments
Open

Mobile support #13

vlrevolution opened this issue Sep 10, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@vlrevolution
Copy link

Could we start to implement mobile support?

I am building a hybrid mobile app and am looking for a md editor and renderer. I've been using https://github.com/ssssota/svelte-exmarkdown so far, but it is only renderer and your package has now come along.

I haven't dove into your specific code yet but could you perhaps be able to tell me if it would be possible to highlight code blocks by https://github.com/shikijs/shiki
I prefer non regex based highlighting for accuracy. Would be a great addition.

I am not able to edit on the demo with my phone, no editor UI comes up so I am assuming youbare only using it on desktop? I would love to help improve the mobile UX but perhaps you are already working on it?

@BearToCode
Copy link
Owner

BearToCode commented Sep 10, 2023

Hi!
For now there's no way to use a custom syntax highlighting, but the change should be quick and I'll implement it in the near future.
Regarding mobile support: for now the default keyboard should pop up, as it is a normal textarea (that works on my phone). What's missing is a way for plugins to add icons to the toolbar and then move the toolbar over the keyboard on phones. Here's a photo that explains it better

I've not started working on this yet, so if you want to contribute to the project you are welcome to do so!

@BearToCode
Copy link
Owner

I just added support for custom syntax highlighting in code blocks in 2.5.0

@BearToCode BearToCode added the enhancement New feature or request label Sep 11, 2023
@BearToCode
Copy link
Owner

Icons now work on mobile as well, the only things that might still be missing are slash commands and emojis

@vlrevolution
Copy link
Author

Looking forward to giving it a spin! Thanks for all the hard work on this, I will probably utilize some of it for markdown editing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants