Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROPOSAL: Add startUI.appBasename option in next.config.js #161

Closed
wants to merge 1 commit into from
Closed

PROPOSAL: Add startUI.appBasename option in next.config.js #161

wants to merge 1 commit into from

Conversation

ivan-dalmet
Copy link
Member

@ivan-dalmet ivan-dalmet commented Feb 4, 2022 •
edited

This is a proposal, I'm not sure if it's clever ou stupide to use the next.config.js to store this information 😅

Fix #157

Change the app basename

Udpate the startUI.appBasename in the next.config.js to change the url where the app (folder) is serve.

ℹ️ Only accept first level path like ✅ admin (❌ sub/path will not work)

// next.config.js
module.exports = {
  startUI: {
    appBasename: 'app',
  },
}

@ivan-dalmet ivan-dalmet self-assigned this Feb 4, 2022
@vercel
Copy link

vercel bot commented Feb 4, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bearstudio/start-ui/F46AwFz1Nmf3zu1HYGokrXieRauM
✅ Preview: https://start-ui-git-feat-constant-for-app-path-bearstudio.vercel.app

@ivan-dalmet ivan-dalmet added the enhancement New feature or request label Feb 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yoannfleurydev yoannfleurydev added the changelog Important changes to read for your Start UI [web] based projects label Mar 23, 2022
@ivan-dalmet
Copy link
Member Author

We don't need this level of complexity. Will close for now.

@ivan-dalmet ivan-dalmet closed this Jul 7, 2022
@ivan-dalmet ivan-dalmet deleted the feat/constant-for-app-path branch November 3, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoannfleurydev yoannfleurydev Awaiting requested review from yoannfleurydev

@DecampsRenan DecampsRenan Awaiting requested review from DecampsRenan

Assignees

@ivan-dalmet ivan-dalmet

Labels
changelog Important changes to read for your Start UI [web] based projects enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allows to change app url
2 participants
@ivan-dalmet @yoannfleurydev