tests: Use git worktree correctly #2117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git worktree -d does not work on all versions of git worktree
|
nope, seems like there is something else in play here |
Hey, @NoahGorny I tried testing on Monterey and didn't get any errors. Could it be specific to big sur? |
|
yes, I have big sur and it happens to me locally aswell. not sure how to debug && fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git worktree -d does not work on all versions of git worktree
this seems to resolve my problems running the tests locally
Description
After debugging the tests_setup a bit, I found out that git worktree call failed. After further testing, it seems like the
-dflag was responsible for the failuresMotivation and Context
Closes #2115
How Has This Been Tested?
By running the tests :)
Types of changes