Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Notice on iOS permissions and App submission - Still a thing? #1170

Open
landliebe opened this issue Sep 27, 2023 · 1 comment
Open
Labels
P2 Important issues not at the top of the work list. type: documentation Update to the documentation

Comments

@landliebe
Copy link

landliebe commented Sep 27, 2023

Hello,
In the current Readme following is stated:

IMPORTANT: You will have to include all permission options when you want to submit your App. This is because the permission_handler plugin touches all different SDKs and because the static code analyser (run by Apple upon App submission) detects this and will assert if it cannot find a matching permission option in the Info.plist. More information about this can be found here.

Only this part is striked through without any further information why it is striked through:

You will have to include all permission options when you want to submit your App.

I checked SO, issues and so on. This was definitely a problem in the past. But is it still? The prepocessor entries in the Podfile: Do they solve this problem, as they prevent the compilation of the unused code for the unused permissions?

If this was fixed with the Podfile entries: It would really help to very clearly state that the "Important: " Notice is not only striked through but also commented like "This was a thing before version x.y.z. This is solved now because of ABC. This information is only still here because ASDF"

Version

11.0.0

@landliebe landliebe changed the title [Question]: [Question]: Notice on iOS permissions abd App submission - Still a thing? Sep 27, 2023
@landliebe landliebe changed the title [Question]: Notice on iOS permissions abd App submission - Still a thing? [Question]: Notice on iOS permissions and App submission - Still a thing? Sep 27, 2023
@mvanbeusekom mvanbeusekom added type: documentation Update to the documentation P2 Important issues not at the top of the work list. labels Sep 28, 2023
@mvanbeusekom
Copy link
Member

Hello @landliebe,

Thank you for submitting this question. I have looked at the documentation and see where your confusion is coming from. I have labelled this issue with the "type: documentation" label, so we can improve on it. However to answer your question:

Since version 8.0.0 of the permission_handler plugin we changed the default behaviour on how permissions are used. Before version 8.0.0 all permissions where included by default and you'd have to explicitly disable all permissions your app didn't need. Since version 8.0.0 the permission_handler by default excludes all permissions and developers only have to enable those that the app really needs.

Enabling permissions is still done using the pre-processor definitions in the ios/Podfile, by declaring them and assigning them with the value 1.

I hope this answers your question, please feel free to leave a comment if you still have additional questions regarding this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issues not at the top of the work list. type: documentation Update to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants