Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement proposal]: move non-flutter models to new package #1512

Closed
8 tasks done
ostk0069 opened this issue May 13, 2024 · 1 comment
Closed
8 tasks done

[Enhancement proposal]: move non-flutter models to new package #1512

ostk0069 opened this issue May 13, 2024 · 1 comment

Comments

@ostk0069
Copy link

Please check the following before submitting a new issue.

Please select affected platform(s)

  • Android
  • iOS
  • Linux
  • macOS
  • Web
  • Windows

Proposal

currently, domain definition models ( such as https://github.com/Baseflow/flutter-geolocator/tree/main/geolocator_platform_interface/lib/src/models ) are non-flutter files.
Therefore, these files are in file geolocator_platform_interface packeage which depends on flutter.
Separating non-flutter domain codes and others looks much nice, I think.

Pitch

This will be very helpful for multiple package apps.

@mvanbeusekom
Copy link
Member

Hi @ostk0069,

These models are specifically meant for the use in the geolocator plugin. We don't intent to otherwise expose these models as that means we will also limit ourselves when updating the models for geolocation purposes.

You are free to copy the classes and use them in you application according to the license specified in the LICENSE file of the package.

@mvanbeusekom mvanbeusekom closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants