Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MaterialInputDialog] Auto focus + close on completion #424

Open
1 of 7 tasks
DominicMaas opened this issue Apr 8, 2021 · 2 comments
Open
1 of 7 tasks

[MaterialInputDialog] Auto focus + close on completion #424

DominicMaas opened this issue Apr 8, 2021 · 2 comments

Comments

@DominicMaas
Copy link

馃殌 Feature Requests

The following discusses my experience on Android, I'm not sure about other platforms.

I'm happy to submit a small PR to auto focus on the text field when the input dialog opens and hook up the completion event to close the dialog when the user taps on the return key (if the positive button is enabled).

Currently you must tap on the text field manually before entering text, and when you're done you must tap on the positive button. This change would make it so that you can simply start typing straight away, and then press the return key to close the dialog (Completion event).

I'm not sure what the side effects of doing this are (and if it's against the Material Design guidelines), so I'm happy to chuck these changes behind an optional flag.

Current Changes

Platforms affected (mark all that apply)

  • 馃摫 iOS
  • 馃 Android
  • 馃弫 WPF
  • 馃寧 UWP
  • 馃崕 MacOS
  • 馃摵 tvOS
  • 馃悞 Xamarin.Forms
@OscarHMG
Copy link

OscarHMG commented Jul 6, 2021

How you can achieve this? (AUTOFOCUS)

@DominicMaas
Copy link
Author

See my "Current Changes" link, I ended up making a copy of the dialog into my own project where I made the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants