Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESCRIBE should follow Transformed response #76

Closed
Barracuda09 opened this issue Nov 8, 2019 · 5 comments
Closed

DESCRIBE should follow Transformed response #76

Barracuda09 opened this issue Nov 8, 2019 · 5 comments
Labels
enhancement Fixed Testers Wanted If like to help out, please test this

Comments

@Barracuda09
Copy link
Owner

Hi @Barracuda09 ,

Another issue detected with the ChildPIPE frontend: The RTCP packets are not confirmant. See the content (from the LOG) when using it with the real frontend disabled and the "transformation" and "advertise" enabled for the virtual frontend:

v=0
o=- 0253037672 0253037672 IN IP4 192.168.1.27
s=SatIPServer:1 0,0,0
t=0 0
m=video 0 RTP/AVP 33
c=IN IP4 0.0.0.0
a=control:stream=3
a=fmtp:33 ver=1.5;tuner=4,240,1,15;exec=None
a=sendonly

So, when using the TRANSFORMATION functionality the a=fmtp:33 ... line requires to be conformant with the selected ADVERSITE mode. If not then some clients refuse to play.

Regards.

Originally posted by @lars18th in #69 (comment)

@Barracuda09 Barracuda09 added enhancement good first issue Please feel free to ask me for pointers help wanted labels Nov 8, 2019
@lars18th
Copy link
Contributor

However, I think this issue requires low priority. Not all SAT>IP clients parse the full a=fmtp:33 line.

@lars18th
Copy link
Contributor

However, I think this issue requires low priority. Not all SAT>IP clients parse the full a=fmtp:33 line.

I've discovered some clients that parse this line. They use it for checking if the requested frequency are tuned when changing the transponder. So, it's required to provide a correct output for these clients.

@Barracuda09
Copy link
Owner Author

Should be fixed with 7107fa5

@Barracuda09 Barracuda09 added Fixed Testers Wanted If like to help out, please test this and removed help wanted good first issue Please feel free to ask me for pointers labels Nov 12, 2022
@lars18th
Copy link
Contributor

Should be fixed with 7107fa5

Yes. So thank you. Only try to fix the current empty pid list bug:
a=fmtp:33 ver=1.0;src=1;tuner=4,240,1,15,11953.5000,h,dvbs,qpsk,off,27500,34;pids=
(described in #169 (comment))

So if you want you can close this issue.

@Barracuda09
Copy link
Owner Author

Close as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Fixed Testers Wanted If like to help out, please test this
Projects
None yet
Development

No branches or pull requests

2 participants