Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing a profile hangs the browser #151

Open
juj opened this issue Apr 18, 2020 · 4 comments
Open

Viewing a profile hangs the browser #151

juj opened this issue Apr 18, 2020 · 4 comments

Comments

@juj
Copy link
Contributor

juj commented Apr 18, 2020

STR:

Capture a profile of

http://clb.confined.space/dump/PolyStyleMedievalVillage_20200418_065906_wasm_release_cpuprofiler/

It is a bit difficult to do due to bug #150, but once one manages to do a capture, there is something about viewing the capture that makes Spector.js hang altogether:

http://clb.confined.space/dump/SpectorJsHangsWhenViewingProfile.mov

Waiting for the UI to become responsive does not work, but the hang keeps occurring.

@sebavan
Copy link
Member

sebavan commented Apr 18, 2020

We have
image

Actually the entire UI has been generated for a number of calls around 5000 This is amazingly rare to have that many commands per frame. I guess it also explains the hanging issue during the capture.

I am not sure If we should support that many calls per frame or not as it sounds really edge case to me regarding most of the projects I have seen so far.

So you think there might be more and more of those experiences around ???

@juj
Copy link
Contributor Author

juj commented Apr 18, 2020

This is amazingly rare to have that many commands per frame.

Yeah, agreed, the page is really heavy with WebGL. However, that is partly the reason why I am looking at it with a WebGL inspector in the first place!

Though it seems to me that this bug report is still valid: why should scrolling the API call list view, or clicking on an item in that list be O(n) to the number of items on the list? It seems that some work is being done that is linear to the number of recorded API calls?

Perhaps there is some state change accumulation tracking taking place? In that case, I'd understand that clicking on an item would be proportional to the number of api calls that took place before the clicked item, but the api calls that come afterwards should not have an effect?

@sebavan
Copy link
Member

sebavan commented Apr 18, 2020

Definitely, it is just me getting stupid when i built the page :-)

What i can propose you if you have a bit of time is to fix it around may the 10th ? I ll have a bit of days off so I should be able to focus on these and the offscreen canvas i would like to support.

@juj
Copy link
Contributor Author

juj commented Apr 19, 2020

Cool, no rush at all! Help is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants