Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainparams.cpp needs updating for clarity of halving strategy #212

Open
bigdaveakers opened this issue Feb 6, 2019 · 2 comments
Open

Comments

@bigdaveakers
Copy link
Contributor

bigdaveakers commented Feb 6, 2019

BTCP halving strategy is currently 210,000 blocks but the code is not clear and still suggests that it is 840,000.

There is a bit shift that reduces this to 210,000 but commentary is not clear. The rebase code appears to address this by setting nSubsidyHalvingInterval directly to 210,000

@mattpass
Copy link
Contributor

mattpass commented Feb 6, 2019

This is the code mentioned above:
https://github.com/BTCPrivate/BitcoinPrivate/blob/6c8ed84c5185fa522b57e08d1494bab2020da39a/src/main.cpp#L1440

Always a good idea to point code out with the URL and line number(s) where possible 😀

@bigdaveakers

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants