Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug in bounds of a bounding box #1446

Open
pawelbaran opened this issue Jan 31, 2024 · 0 comments
Open

Potential bug in bounds of a bounding box #1446

pawelbaran opened this issue Jan 31, 2024 · 0 comments
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@pawelbaran
Copy link
Member

pawelbaran commented Jan 31, 2024

Description:

From the conversation with @michal-pekacki:

  • it looks like BoundsOfTransformed contains a bug, these lines should already operate on 8 points instead of 2 (transforming min/max will yield a wrong bounding box, we need to transform all 8 corners) - Query.CornerPoints can be helpful
  • also the method can be simplified: take all 8 corners, then transform by local transform of bbox, then by the extra transform param, finally get bounds of transformed points
  • transform input could be made optional and method renamed to simply Bounds to align with existing methods
  • let's make sure we have tests for it 😉
@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

2 participants