Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefObjects do not capture the link information on FromRevit converts #1241

Open
pawelbaran opened this issue Aug 18, 2022 · 2 comments
Open

RefObjects do not capture the link information on FromRevit converts #1241

pawelbaran opened this issue Aug 18, 2022 · 2 comments
Assignees
@pawelbaran
Labels
type:bug Error or unexpected behaviour
Projects
Revit_Toolkit Priority

Comments

@pawelbaran
Copy link
Member

Description:

Currently refObjects on FromRevit converts use ElementId as key. This is not enough in case of linked models: in the extreme situation there could be objects of same time in two models, resulting in incorrect object being returned for one of them.

Important: CachePanelGeometry will require similar rework too, also material graded elements.
@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Aug 18, 2022
@pawelbaran pawelbaran self-assigned this Aug 18, 2022
@pawelbaran pawelbaran added this to Backlog in Revit_Toolkit Priority via automation Aug 18, 2022
@vietle-bh
Copy link
Contributor

I believe you meant "there could be objects of same ID in two models".

@pawelbaran
Copy link
Member Author

You are right @vietle-bh, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelbaran pawelbaran

Labels
type:bug Error or unexpected behaviour
Projects
Revit_Toolkit Priority
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pawelbaran @vietle-bh