Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability for an event participant to have None hours earned #1162

Open
bledsoef opened this issue Mar 20, 2024 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers in trello summer cohort

Comments

@bledsoef
Copy link
Contributor

Low priority issue, leave for summer cohort

The EventParticipant model having a nullable hoursEarned field is old functionality leftover from when EventParticipant and EventRsvp were the same table. There really shouldn't be a case when their hours earned is None, at the very least it should only be 0. We need to change the following:

  • The EventParticipant model's hoursEarned field
  • Test data where hoursEarned is set to 0
  • Tests that test for hoursEarned to be None (at least one is in test_spreadsheet
  • Make sure there isn't any place in logic where we are setting their hoursEarned values
@bledsoef bledsoef added enhancement New feature or request good first issue Good for newcomers summer cohort in trello labels Mar 20, 2024
@bledsoef
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers in trello summer cohort
Projects
None yet
Development

No branches or pull requests

1 participant