Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample CosmosDB extension - Trigger name format doesn't match other trigger names #6

Open
ecfan opened this issue May 10, 2022 · 2 comments
Assignees

Comments

@ecfan
Copy link
Member

ecfan commented May 10, 2022

@praveensri: I'm using the Cosmos DB example to show how you can create a custom built-in connector for Standard logic apps. However, I see that the trigger name in the sample is "Receive document", which doesn't follow the convention for trigger names and sounds more like an action. This inconsistency is very apparent when compared to other Cosmos DB trigger names:

image

To set up a good model, can we change the name to something like "When a document is received"? That way, if the customer uses the sample code, they get a version that follows the correct naming convention. Thanks!

Here's the file where I found the trigger name:

https://github.com/Azure/logicapps-connector-extensions/blob/CosmosDB/src/CosmosDB/Providers/CosmosDbServiceOperationProvider.cs

@ecfan
Copy link
Member Author

ecfan commented May 10, 2022

#assign @praveensri

@ecfan
Copy link
Member Author

ecfan commented Jul 13, 2022

@praveensri: Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants