Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Req] Disconnect links when maximum message size changes #705

Open
jsquire opened this issue May 10, 2024 · 3 comments
Open

[Feature Req] Disconnect links when maximum message size changes #705

jsquire opened this issue May 10, 2024 · 3 comments

Comments

@jsquire
Copy link
Member

jsquire commented May 10, 2024

Problem statement

When using a ServiceBusMessageSender instance while there's a change to the entity's maximum message size, the Batch API is unaware of the change and doesn't allow messages to be added despite the message being within the allowed size. The client holds on to the old maximum message size it has retrieved from the entity, which is confusing.

This occurs because the maximum message size is communicated to the client via property on the AMQP link when it is established. If the maximum message size for the entity changes, any links that were already opened have the wrong metadata associated with them.

Requested feature

When changes are made to entity settings that would impact how the client interacts with the service, the service should force-detatch existing AMQP links and/or connections to ensure that the client must establish a new one with the latest service metadata.

References and related

@jsquire
Copy link
Member Author

jsquire commented May 10, 2024

//cc: @EldertGrootenboer

@SeanFeldman
Copy link
Contributor

Cheering for this to happen in 2024 🤞

@EldertGrootenboer
Copy link
Contributor

Thank you for suggesting this feature. We have opened an investigation task for this in our backlog, and will update this issue when we have more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants